OpenVZ Forum


Home » Mailing lists » Devel » [PATCH v2] NFSd: simplify locking in nfsd_recall_delegations()
[PATCH v2] NFSd: simplify locking in nfsd_recall_delegations() [message #47063] Tue, 03 July 2012 13:02 Go to previous message
Stanislav Kinsbursky is currently offline  Stanislav Kinsbursky
Messages: 683
Registered: October 2011
Senior Member
v2: rebased on 3.5-rc3 kernel

Holding of client_mutex looks redundant here - recall_lock looks enough.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
fs/nfsd/nfs4state.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 33eccee..480ecc9 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4622,7 +4622,6 @@ void nfsd_recall_delegations(u64 num)
LIST_HEAD(victims);
struct nfs4_delegation *dp, *dnext;

- nfs4_lock_state();
spin_lock(&recall_lock);
count = nfsd_process_n_delegations(num, &victims);
list_for_each_entry_safe(dp, dnext, &victims, dl_recall_lru) {
@@ -4630,7 +4629,6 @@ void nfsd_recall_delegations(u64 num)
nfsd_break_one_deleg(dp);
}
spin_unlock(&recall_lock);
- nfs4_unlock_state();

printk(KERN_INFO "NFSD: Recalled %d delegations", count);
}
 
Read Message
Read Message
Previous Topic: [PATCH v2] NFSd: fix locking in nfsd_forget_delegations()
Next Topic: [PATCH] fix bad behavior in use_hierarchy file
Goto Forum:
  


Current Time: Mon Nov 04 00:08:15 GMT 2024

Total time taken to generate the page: 0.03546 seconds