OpenVZ Forum: Devel » [PATCH v4 00/25] kmem limitation for memcg

Home » Mailing lists » Devel » [PATCH v4 00/25] kmem limitation for memcg

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v4 19/25] memcg: disable kmem code when not in use. [message #46850 is a reply to message #46849]

Mon, 18 June 2012 12:26

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

>>
>> static void drain_all_stock_async(struct mem_cgroup *memcg);
>> @@ -4344,8 +4358,13 @@ static int mem_cgroup_write(struct cgroup *cont, struct cftype *cft,
>> *
>> * But it is not worth the trouble
>> */
>> - if (!memcg->kmem_accounted&& val != RESOURCE_MAX)
>> + mutex_lock(&set_limit_mutex);
>> + if (!memcg->kmem_accounted&& val != RESOURCE_MAX
>> + && !memcg->kmem_accounted) {
>
> I'm sorry why you check the value twice ?
>

Hi Kame,

For no reason, it should be removed. I never noticed this because 1)
This is the kind of thing testing will never reveal, and 2), this
actually goes away in a later patch (memcg: propagate kmem limiting
information to children)

In any case, I will update my tree here.

Thanks for spotting this

Report message to a moderator

[Message index]

		[PATCH v4 00/25] kmem limitation for memcg By: Glauber Costa on Mon, 18 June 2012 10:27
		[PATCH v4 08/25] memcg: change defines to an enum By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 08/25] memcg: change defines to an enum By: Michal Hocko on Wed, 20 June 2012 13:13
		[PATCH v4 06/25] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Mon, 18 June 2012 10:27
		Re: [PATCH v4 06/25] memcg: Make it possible to use the stock for more than one page. By: Michal Hocko on Wed, 20 June 2012 13:28
		Re: [PATCH v4 06/25] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Wed, 20 June 2012 19:36
		Re: [PATCH v4 06/25] memcg: Make it possible to use the stock for more than one page. By: Michal Hocko on Thu, 21 June 2012 21:14
		Re: [PATCH v4 06/25] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Mon, 25 June 2012 13:03
		[PATCH v4 04/25] Wipe out CFLGS_OFF_SLAB from flags during initial slab creation By: Glauber Costa on Mon, 18 June 2012 10:27
		[PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Michal Hocko on Wed, 20 June 2012 13:47
		Re: [PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Glauber Costa on Wed, 20 June 2012 19:43
		Re: [PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Michal Hocko on Thu, 21 June 2012 21:19
		Re: [PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Glauber Costa on Mon, 25 June 2012 13:13
		Re: [PATCH v4 07/25] memcg: Reclaim when more than one page needed. By: Glauber Costa on Mon, 25 June 2012 14:04
		[PATCH v4 09/25] kmem slab accounting basic infrastructure By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 01/25] slab: rename gfpflags to allocflags By: Glauber Costa on Mon, 18 June 2012 10:27
		[PATCH v4 11/25] consider a memcg parameter in kmem_create_cache By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 03/25] slab: move FULL state transition to an initcall By: Glauber Costa on Mon, 18 June 2012 10:27
		[PATCH v4 10/25] slab/slub: struct memcg_params By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: Glauber Costa on Mon, 18 June 2012 10:27
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: KAMEZAWA Hiroyuki on Mon, 18 June 2012 12:07
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: Glauber Costa on Mon, 18 June 2012 12:10
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: KAMEZAWA Hiroyuki on Tue, 19 June 2012 00:11
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: Pekka Enberg on Wed, 20 June 2012 07:32
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: Glauber Costa on Wed, 20 June 2012 08:40
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: KAMEZAWA Hiroyuki on Thu, 21 June 2012 11:39
		Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() By: Michal Hocko on Wed, 20 June 2012 13:20
		[PATCH v4 02/25] provide a common place for initcall processing in kmem_cache By: Glauber Costa on Mon, 18 June 2012 10:27
		[PATCH v4 13/25] Add a __GFP_SLABMEMCG flag By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 12/25] sl[au]b: always get the cache from its page in kfree By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 15/25] allow enable_cpu_cache to use preset values for its tunables By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 14/25] memcg: kmem controller dispatch infrastructure By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 16/25] don't do __ClearPageSlab before freeing slab page. By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 17/25] skip memcg kmem allocations in specified code regions By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 17/25] skip memcg kmem allocations in specified code regions By: KAMEZAWA Hiroyuki on Mon, 18 June 2012 12:19
		[PATCH v4 19/25] memcg: disable kmem code when not in use. By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 19/25] memcg: disable kmem code when not in use. By: KAMEZAWA Hiroyuki on Mon, 18 June 2012 12:22
		Re: [PATCH v4 19/25] memcg: disable kmem code when not in use. By: Glauber Costa on Mon, 18 June 2012 12:26
		[PATCH v4 18/25] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 20/25] memcg: destroy memcg caches By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 21/25] Track all the memcg children of a kmem_cache. By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 22/25] slab: slab-specific propagation changes. By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 25/25] Documentation: add documentation for slab tracker for memcg By: Glauber Costa on Mon, 18 June 2012 10:28
		[PATCH v4 24/25] memcg/slub: shrink dead caches By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 24/25] memcg/slub: shrink dead caches By: Christoph Lameter on Fri, 06 July 2012 15:16
		Re: [PATCH v4 24/25] memcg/slub: shrink dead caches By: Glauber Costa on Fri, 20 July 2012 22:16
		Re: [PATCH v4 24/25] memcg/slub: shrink dead caches By: Christoph Lameter on Wed, 25 July 2012 15:23
		Re: [PATCH v4 24/25] memcg/slub: shrink dead caches By: Glauber Costa on Wed, 25 July 2012 18:15
		[PATCH v4 23/25] memcg: propagate kmem limiting information to children By: Glauber Costa on Mon, 18 June 2012 10:28
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: KAMEZAWA Hiroyuki on Mon, 18 June 2012 12:37
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: Glauber Costa on Mon, 18 June 2012 12:43
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: KAMEZAWA Hiroyuki on Tue, 19 June 2012 00:16
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: Glauber Costa on Tue, 19 June 2012 08:35
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: Glauber Costa on Tue, 19 June 2012 08:54
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: Glauber Costa on Wed, 20 June 2012 08:59
		Re: [PATCH v4 23/25] memcg: propagate kmem limiting information to children By: KAMEZAWA Hiroyuki on Sat, 23 June 2012 04:19
		Re: [PATCH v4 00/25] kmem limitation for memcg By: KAMEZAWA Hiroyuki on Mon, 18 June 2012 12:10
		Re: [PATCH v4 00/25] kmem limitation for memcg By: Glauber Costa on Mon, 18 June 2012 12:14

Previous Topic:	[PATCH] provide a common place for initcall processing in kmem_cache
Next Topic:	[PATCH] SUNRPC: return negative value in case rpcbind client creation error

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Aug 25 01:23:27 GMT 2024

Total time taken to generate the page: 0.03309 seconds