OpenVZ Forum


Home » Mailing lists » Devel » [PATCH v3 0/6] per cgroup /proc/stat statistics
Re: [PATCH v3 1/6] measure exec_clock for rt sched entities [message #46613 is a reply to message #46610] Wed, 30 May 2012 10:42 Go to previous messageGo to previous message
Peter Zijlstra is currently offline  Peter Zijlstra
Messages: 61
Registered: September 2006
Member
On Wed, 2012-05-30 at 14:32 +0400, Glauber Costa wrote:
> >> + for_each_sched_rt_entity(rt_se) {
> >> + rt_rq = rt_rq_of_se(rt_se);
> >> + schedstat_add(rt_rq, exec_clock, delta_exec);
> >> + }
> >> +
> >> if (!rt_bandwidth_enabled())
> >> return;
> >
> > See, this just makes me sad.. you now have a double
> > for_each_sched_rt_entity() loop.
>
> The way I read the rt.c code, it it is called from enqueue_task_rt only
> once.

Ah, what I meant was, right after that !rt_bandwidth_enabled() muck we
do another for_each_sched_rt_entity() walk.
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH v3 2/6] account guest time per-cgroup as well.
Next Topic: [PATCH 0/2] NFS: callback shutdown panic fix
Goto Forum:
  


Current Time: Mon Sep 09 07:16:36 GMT 2024

Total time taken to generate the page: 0.04446 seconds