OpenVZ Forum: Devel » [PATCH v3 00/28] kmem limitation for memcg

Home » Mailing lists » Devel » [PATCH v3 00/28] kmem limitation for memcg

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v3 15/28] slub: always get the cache from its page in kfree [message #46566 is a reply to message #46535]

Tue, 29 May 2012 14:42

Christoph Lameter
Messages: 123
Registered: September 2006

Senior Member

On Fri, 25 May 2012, Glauber Costa wrote:

> struct page already have this information. If we start chaining
> caches, this information will always be more trustworthy than
> whatever is passed into the function

Yes but the lookup of the page struct also costs some cycles. SLAB in
!NUMA mode and SLOB avoid these lookups and can improve their freeing
speed because of that.

> diff --git a/mm/slub.c b/mm/slub.c
> index 0eb9e72..640872f 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2598,10 +2598,14 @@ redo:
> void kmem_cache_free(struct kmem_cache *s, void *x)
> {
> struct page *page;
> + bool slab_match;
>
> page = virt_to_head_page(x);
>
> - slab_free(s, page, x, _RET_IP_);
> + slab_match = (page->slab == s) | slab_is_parent(page->slab, s);
> + VM_BUG_ON(!slab_match);

Why add a slab_match bool if you do not really need it?

Report message to a moderator

[Message index]

		[PATCH v3 00/28] kmem limitation for memcg By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 02/28] memcg: Always free struct memcg through schedule_work() By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 09/28] kmem slab accounting basic infrastructure By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 08/28] res_counter: don't force return value checking in res_counter_charge_nofail By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 03/28] slab: rename gfpflags to allocflags By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 01/28] slab: move FULL state transition to an initcall By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 18/28] slub: charge allocation to a memcg By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 18/28] slub: charge allocation to a memcg By: Christoph Lameter on Tue, 29 May 2012 14:51
		Re: [PATCH v3 18/28] slub: charge allocation to a memcg By: Glauber Costa on Tue, 29 May 2012 16:06
		[PATCH v3 20/28] memcg: disable kmem code when not in use. By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 22/28] memcg/slub: shrink dead caches By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 19/28] slab: per-memcg accounting of slab caches By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 19/28] slab: per-memcg accounting of slab caches By: Christoph Lameter on Tue, 29 May 2012 14:52
		Re: [PATCH v3 19/28] slab: per-memcg accounting of slab caches By: Glauber Costa on Tue, 29 May 2012 16:07
		Re: [PATCH v3 19/28] slab: per-memcg accounting of slab caches By: Glauber Costa on Tue, 29 May 2012 16:13
		[PATCH v3 21/28] memcg: destroy memcg caches By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 25/28] slub: create slabinfo file for memcg By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Christoph Lameter on Tue, 29 May 2012 14:47
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Tue, 29 May 2012 16:00
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 12:17
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 12:26
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 12:34
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 12:38
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 13:11
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 13:09
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 13:04
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 13:06
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 13:37
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 13:37
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 13:53
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 13:55
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Frederic Weisbecker on Wed, 30 May 2012 15:33
		Re: [PATCH v3 16/28] memcg: kmem controller charge/uncharge infrastructure By: Glauber Costa on Wed, 30 May 2012 16:16
		[PATCH v3 24/28] memcg: Per-memcg memory.kmem.slabinfo file. By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 06/28] slab: use obj_size field of struct kmem_cache when not debugging By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 10/28] slab/slub: struct memcg_params By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Christoph Lameter on Tue, 29 May 2012 14:27
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Glauber Costa on Tue, 29 May 2012 15:50
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Christoph Lameter on Tue, 29 May 2012 16:33
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Glauber Costa on Tue, 29 May 2012 16:36
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Christoph Lameter on Tue, 29 May 2012 16:52
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Glauber Costa on Tue, 29 May 2012 16:59
		Re: [PATCH v3 12/28] slab: pass memcg parameter to kmem_cache_create By: Frederic Weisbecker on Wed, 30 May 2012 11:01
		[PATCH v3 14/28] slab: create duplicate cache By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 15/28] slub: always get the cache from its page in kfree By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 15/28] slub: always get the cache from its page in kfree By: Christoph Lameter on Tue, 29 May 2012 14:42
		Re: [PATCH v3 15/28] slub: always get the cache from its page in kfree By: Glauber Costa on Tue, 29 May 2012 15:59
		[PATCH v3 17/28] skip memcg kmem allocations in specified code regions By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 14:36
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 15:56
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 16:05
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 17:05
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 17:25
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 17:27
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 19:26
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 19:40
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 19:55
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 20:08
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Tue, 29 May 2012 20:21
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Tue, 29 May 2012 20:25
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Tejun Heo on Wed, 30 May 2012 01:29
		Re: Re: [PATCH v3 13/28] slub: create duplicate cache By: James Bottomley on Wed, 30 May 2012 07:28
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Glauber Costa on Wed, 30 May 2012 07:54
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Tejun Heo on Wed, 30 May 2012 08:02
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Christoph Lameter on Wed, 30 May 2012 15:37
		Re: [PATCH v3 13/28] slub: create duplicate cache By: Suleiman Souhlal on Tue, 29 May 2012 20:57
		[PATCH v3 11/28] slub: consider a memcg parameter in kmem_create_cache By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 26/28] slub: track all children of a kmem cache By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 28/28] Documentation: add documentation for slab tracker for memcg By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 23/28] slab: Track all the memcg children of a kmem_cache. By: Glauber Costa on Fri, 25 May 2012 13:03
		[PATCH v3 27/28] memcg: propagate kmem limiting information to children By: Glauber Costa on Fri, 25 May 2012 13:03
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Michal Hocko on Fri, 25 May 2012 13:34
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Christoph Lameter on Fri, 25 May 2012 14:34
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Glauber Costa on Mon, 28 May 2012 08:32
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Christoph Lameter on Tue, 29 May 2012 15:07
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Glauber Costa on Tue, 29 May 2012 15:44
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Christoph Lameter on Tue, 29 May 2012 16:01
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Frederic Weisbecker on Thu, 07 June 2012 10:26
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Glauber Costa on Thu, 07 June 2012 10:53
		Re: [PATCH v3 00/28] kmem limitation for memcg By: Frederic Weisbecker on Thu, 07 June 2012 14:00
		Re: [PATCH v3 00/28] kmem limitation for memcg By: KAMEZAWA Hiroyuki on Thu, 14 June 2012 02:24

Previous Topic:	[PATCH] NFS: hard-code init_net for NFS callback transports
Next Topic:	[PATCH v4 0/4] per cgroup cpu statistics

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Aug 31 09:46:32 GMT 2025

Total time taken to generate the page: 0.08515 seconds