OpenVZ Forum: Devel » [PATCH] NFS: init client before declaration

Home » Mailing lists » Devel » [PATCH] NFS: init client before declaration

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] NFS: init client before declaration [message #46469 is a reply to message #46461]

Tue, 22 May 2012 14:29

Myklebust, Trond
Messages: 52
Registered: November 2011

Member

On Tue, 2012-05-22 at 16:40 +0400, Stanislav Kinsbursky wrote:
> Client have to be initialized prior to adding it to per-net clients list,
> because otherwise there are races, shown below:
>
> CPU#0 CPU#1
> _____ _____
>
> nfs_get_client
> nfs_alloc_client
> list_add(..., nfs_client_list)
> rpc_fill_super
> rpc_pipefs_event
> nfs_get_client_for_event
> __rpc_pipefs_event
> (clp->cl_rpcclient is uninitialized)
> BUG()
> init_client
> clp->cl_rpcclient = ...
>

Why not simply change nfs_get_client_for_event() so that it doesn't
touch nfs_clients that have clp->cl_cons_state!=NFS_CS_READY?

That should ensure that it doesn't touch nfs_clients that failed to
initialise and/or are still in the process of being initialised.

Cheers
Trond

--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

Report message to a moderator

[Message index]

		[PATCH] NFS: init client before declaration By: Stanislav Kinsbursky on Tue, 22 May 2012 12:40
		Re: [PATCH] NFS: init client before declaration By: Chuck Lever on Tue, 22 May 2012 13:47
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Tue, 22 May 2012 14:29
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Tue, 22 May 2012 15:00
		Re: [PATCH] NFS: init client before declaration By: Stanislav Kinsbursky on Tue, 22 May 2012 15:29
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Tue, 22 May 2012 15:51
		Re: [PATCH] NFS: init client before declaration By: Stanislav Kinsbursky on Tue, 22 May 2012 16:18
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Tue, 22 May 2012 16:43
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Tue, 22 May 2012 20:32
		Re: [PATCH] NFS: init client before declaration By: Stanislav Kinsbursky on Wed, 23 May 2012 11:30
		Re: [PATCH] NFS: init client before declaration By: Kinsbursky Stanislav on Wed, 23 May 2012 12:09
		Re: [PATCH] NFS: init client before declaration By: Myklebust, Trond on Wed, 23 May 2012 13:57
		Re: [PATCH] NFS: init client before declaration By: Stanislav Kinsbursky on Tue, 22 May 2012 15:03

Previous Topic:	[PATCH v2 00/12] NFS: callback threads containerization
Next Topic:	[PATCH v6 0/2] fix static_key disabling problem in memcg

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Apr 17 14:57:21 GMT 2026

Total time taken to generate the page: 0.87389 seconds