OpenVZ Forum: Devel » [PATCH v5 0/2] fix static

Home » Mailing lists » Devel » [PATCH v5 0/2] fix static_key disabling problem in memcg

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v5 2/2] decrement static keys on real destroy time [message #46354 is a reply to message #46348]

Mon, 14 May 2012 01:38

Li Zefan
Messages: 90
Registered: February 2008

Member

> +static void disarm_static_keys(struct mem_cgroup *memcg)

> +{
> +#ifdef CONFIG_INET
> + if (memcg->tcp_mem.cg_proto.activated)
> + static_key_slow_dec(&memcg_socket_limit_enabled);
> +#endif
> +}

Move this inside the ifdef/endif below ?

Otherwise I think you'll get compile error if !CONFIG_INET...

> +
> #ifdef CONFIG_INET
> struct cg_proto *tcp_proto_cgroup(struct mem_cgroup *memcg)
> {
> @@ -452,6 +462,11 @@ struct cg_proto *tcp_proto_cgroup(struct mem_cgroup *memcg)
> }
> EXPORT_SYMBOL(tcp_proto_cgroup);
> #endif /* CONFIG_INET */
> +#else
> +static inline void disarm_static_keys(struct mem_cgroup *memcg)
> +{
> +}
> +
> #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */

Report message to a moderator

[Message index]

		[PATCH v5 0/2] fix static_key disabling problem in memcg By: Glauber Costa on Fri, 11 May 2012 20:11
		[PATCH v5 1/2] Always free struct memcg through schedule_work() By: Glauber Costa on Fri, 11 May 2012 20:11
		Re: [PATCH v5 1/2] Always free struct memcg through schedule_work() By: KAMEZAWA Hiroyuki on Mon, 14 May 2012 00:56
		[PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Fri, 11 May 2012 20:11
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Mon, 14 May 2012 00:59
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Wed, 16 May 2012 06:03
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Wed, 16 May 2012 07:04
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Wed, 16 May 2012 08:28
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Wed, 16 May 2012 08:30
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Wed, 16 May 2012 08:37
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Li Zefan on Mon, 14 May 2012 01:38
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Wed, 16 May 2012 07:03
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: akpm on Wed, 16 May 2012 20:57
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Tejun Heo on Mon, 14 May 2012 18:12
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: akpm on Wed, 16 May 2012 21:06
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Thu, 17 May 2012 03:06
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: akpm on Thu, 17 May 2012 05:37
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Thu, 17 May 2012 09:52
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Thu, 17 May 2012 10:18
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Thu, 17 May 2012 10:22
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Thu, 17 May 2012 10:27
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Tejun Heo on Thu, 17 May 2012 15:19
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: akpm on Thu, 17 May 2012 17:02
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: akpm on Wed, 16 May 2012 21:13
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Thu, 17 May 2012 00:07
		Re: [PATCH v5 2/2] decrement static keys on real destroy time By: Glauber Costa on Thu, 17 May 2012 03:09

Previous Topic:	[PATCH v2 00/29] kmem limitation for memcg
Next Topic:	[RFC PATCH] SUNRPC: protect service sockets lists during per-net shutdown

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jun 29 15:14:13 GMT 2025

Total time taken to generate the page: 0.02011 seconds