OpenVZ Forum: Devel » [PATCH v2 0/5] Fix problem with static

Home » Mailing lists » Devel » [PATCH v2 0/5] Fix problem with static_key decrement

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v2 1/5] don't attach a task to a dead cgroup [message #46042 is a reply to message #46032]

Tue, 24 April 2012 02:20

KAMEZAWA Hiroyuki
Messages: 463
Registered: September 2006

Senior Member

(2012/04/24 4:37), Glauber Costa wrote:

> Not all external callers of cgroup_attach_task() test to
> see if the cgroup is still live - the internal callers at
> cgroup.c does.
>
> With this test in cgroup_attach_task, we can assure that
> no tasks are ever moved to a cgroup that is past its
> destruction point and was already marked as dead.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> CC: Tejun Heo <tj@kernel.org>
> CC: Li Zefan <lizefan@huawei.com>
> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

> ---
> kernel/cgroup.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index b61b938..932c318 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -1927,6 +1927,9 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
> struct cgroup_taskset tset = { };
> struct css_set *newcg;
>
> + if (cgroup_is_removed(cgrp))
> + return -ENODEV;
> +
> /* @tsk either already exited or can't exit until the end */
> if (tsk->flags & PF_EXITING)
> return -ESRCH;

Report message to a moderator

[Message index]

		[PATCH v2 0/5] Fix problem with static_key decrement By: Glauber Costa on Mon, 23 April 2012 19:37
		[PATCH v2 1/5] don't attach a task to a dead cgroup By: Glauber Costa on Mon, 23 April 2012 19:37
		Re: [PATCH v2 1/5] don't attach a task to a dead cgroup By: KAMEZAWA Hiroyuki on Tue, 24 April 2012 02:20
		[PATCH v2 2/5] blkcg: protect blkcg->policy_list By: Glauber Costa on Mon, 23 April 2012 19:37
		[PATCH v2 3/5] change number_of_cpusets to an atomic By: Glauber Costa on Mon, 23 April 2012 19:37
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: KAMEZAWA Hiroyuki on Tue, 24 April 2012 02:25
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: Christoph Lameter on Tue, 24 April 2012 15:02
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: Glauber Costa on Tue, 24 April 2012 16:15
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: Christoph Lameter on Tue, 24 April 2012 16:24
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: Glauber Costa on Tue, 24 April 2012 16:30
		Re: [PATCH v2 3/5] change number_of_cpusets to an atomic By: Christoph Lameter on Tue, 24 April 2012 18:27
		[PATCH v2 4/5] don't take cgroup_mutex in destroy() By: Glauber Costa on Mon, 23 April 2012 19:37
		Re: [PATCH v2 4/5] don't take cgroup_mutex in destroy() By: KAMEZAWA Hiroyuki on Tue, 24 April 2012 02:31
		Re: [PATCH v2 4/5] don't take cgroup_mutex in destroy() By: Glauber Costa on Tue, 24 April 2012 11:42
		Re: [PATCH v2 4/5] don't take cgroup_mutex in destroy() By: Li Zefan on Wed, 25 April 2012 08:01
		[PATCH v2 5/5] decrement static keys on real destroy time By: Glauber Costa on Mon, 23 April 2012 19:37
		Re: [PATCH v2 5/5] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Tue, 24 April 2012 02:40
		Re: [PATCH v2 5/5] decrement static keys on real destroy time By: Glauber Costa on Tue, 24 April 2012 11:41
		Re: [PATCH v2 5/5] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Wed, 25 April 2012 00:22

Previous Topic:	[PATCH 0/3] Fix problem with static_key decrement
Next Topic:	[PATCH 1/6] LockD: pass service to per-net up and down functions

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Dec 02 18:28:03 GMT 2025

Total time taken to generate the page: 0.46749 seconds