OpenVZ Forum: Devel » [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events

Home » Mailing lists » Devel » [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events [message #45938 is a reply to message #45937]

Thu, 19 April 2012 11:36

Stanislav Kinsbursky is currently offline

Stanislav Kinsbursky
Messages: 683
Registered: October 2011

Senior Member

Sorry, but ignore this patch too.
It can't be that simple because of these cl_count tricks in rpc_release_client...

19.04.2012 14:57, Stanislav Kinsbursky пишет:
> These clients can't be safely dereferenced if their counter in 0.
>
> Signee-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> ---
> net/sunrpc/clnt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index 6797246..591994d 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -218,7 +218,8 @@ static struct rpc_clnt *rpc_get_client_for_event(struct net *net, int event)
> if (((event == RPC_PIPEFS_MOUNT)&& clnt->cl_dentry) ||
> ((event == RPC_PIPEFS_UMOUNT)&& !clnt->cl_dentry))
> continue;
> - atomic_inc(&clnt->cl_count);
> + if (atomic_inc_return(&clnt->cl_count) == 1)
> + continue;
> spin_unlock(&sn->rpc_client_lock);
> return clnt;
> }
>

--
Best regards,
Stanislav Kinsbursky

Report message to a moderator

[Message index]

		[PATCH] SUNRPC: skip dead but not buried clients on PipeFS events By: Stanislav Kinsbursky on Thu, 19 April 2012 10:57
		Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events By: Stanislav Kinsbursky on Thu, 19 April 2012 11:36
		Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events By: bfields on Thu, 19 April 2012 21:40
		Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events By: Stanislav Kinsbursky on Fri, 20 April 2012 06:05

Previous Topic:	[PATCH] LockD: call per-net shutdown on every global shutdown call
Next Topic:	[PATCH 1/3] SUNRPC: skip clients with program without PipeFS entries

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Apr 12 14:57:56 GMT 2026

Total time taken to generate the page: 0.44716 seconds