OpenVZ Forum: Devel » [PATCH] slub: don't create a copy of the name string in kmem_cache

Home » Mailing lists » Devel » [PATCH] slub: don't create a copy of the name string in kmem_cache_create

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] slub: don't create a copy of the name string in kmem_cache_create [message #45921 is a reply to message #45911]

Mon, 16 April 2012 14:02

Christoph Lameter
Messages: 123
Registered: September 2006

Senior Member

On Fri, 13 Apr 2012, Glauber Costa wrote:

> When creating a cache, slub keeps a copy of the cache name through
> strdup. The slab however, doesn't do that. This means that everyone
> registering caches have to keep a copy themselves anyway, since code
> needs to work on all allocators.
>
> Having slab create a copy of it as well may very well be the right
> thing to do: but at this point, the callers are already there

What would break if we would add that to slab? I think this is more robust
because right now slab relies on the caller not freeing the string.

Report message to a moderator

[Message index]

		[PATCH] slub: don't create a copy of the name string in kmem_cache_create By: Glauber Costa on Fri, 13 April 2012 21:06
		Re: [PATCH] slub: don't create a copy of the name string in kmem_cache_create By: Christoph Lameter on Mon, 16 April 2012 14:02
		Re: [PATCH] slub: don't create a copy of the name string in kmem_cache_create By: Glauber Costa on Mon, 16 April 2012 14:41

Previous Topic:	[PATCH] remove BUG() in possible but rare condition
Next Topic:	CfP 7th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'12)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Dec 12 20:35:54 GMT 2025

Total time taken to generate the page: 0.28978 seconds