OpenVZ Forum: Devel » [PATCH] remove BUG() in possible but rare condition

Home » Mailing lists » Devel » [PATCH] remove BUG() in possible but rare condition

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] remove BUG() in possible but rare condition [message #45902 is a reply to message #45901]

Wed, 11 April 2012 21:12

akpm
Messages: 224
Registered: March 2007

Senior Member

On Wed, 11 Apr 2012 17:51:57 -0300
Glauber Costa <glommer@parallels.com> wrote:

> On 04/11/2012 05:26 PM, Andrew Morton wrote:
> >>
> >> > failed:
> >> > - BUG();
> >> > unlock_page(page);
> >> > page_cache_release(page);
> >> > return NULL;
> > Cute.
> >
> > AFAICT what happened was that in my April 2002 rewrite of this code I
> > put a non-fatal buffer_error() warning in that case to tell us that
> > something bad happened.
> >
> > Years later we removed the temporary buffer_error() and mistakenly
> > replaced that warning with a BUG(). Only it*can* happen.
> >
> > We can remove the BUG() and fix up callers, or we can pass retry=1 into
> > alloc_page_buffers(), so grow_dev_page() "cannot fail". Immortal
> > functions are a silly fiction, so we should remove the BUG() and fix up
> > callers.
> >
> Any particular caller you are concerned with ?

Didn't someone see a buggy caller in btrfs?

I'm thinking that we should retain some sort of assertion (a WARN_ON)
if the try_to_free_buffers() failed. This is a weird case which I
assume handles the situation where a blockdev's blocksize has changed.
The code tries to throw away the old wrongly-sized buffer_heads and to
then add new correctly-sized ones. If that discarding of buffers
fails then the kernel is in rather a mess.

It's quite possible that this code is never executed - we _should_ have
invalidated all the pagecache for that device when changing blocksize.
Or maybe it *is* executed, I dunno. It's one of those things which has
hung around for decades as code in other places has vastly changed.

Report message to a moderator

[Message index]

		[PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:10
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 18:48
		Re: [PATCH] remove BUG() in possible but rare condition By: Linus Torvalds on Wed, 11 April 2012 18:57
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 19:02
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:25
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 19:20
		Re: [PATCH] remove BUG() in possible but rare condition By: Jiri Kosina on Wed, 11 April 2012 21:33
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 18:59
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 20:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Glauber Costa on Wed, 11 April 2012 20:51
		Re: [PATCH] remove BUG() in possible but rare condition By: akpm on Wed, 11 April 2012 21:12
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Wed, 11 April 2012 21:26
		Re: [PATCH] remove BUG() in possible but rare condition By: Michal Hocko on Thu, 12 April 2012 09:24

Previous Topic:	[PATCH 0/4] nfsd: containerize export and expkey caches
Next Topic:	[PATCH] slub: don't create a copy of the name string in kmem_cache_create

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Aug 29 20:59:57 GMT 2025

Total time taken to generate the page: 0.06674 seconds