| Re: [PATCH 04/10] memcg: Introduce __GFP_NOACCOUNT. [message #45802 is a reply to message #45374] |
Wed, 29 February 2012 19:09  |
Suleiman Souhlal
Messages: 64
Registered: February 2012
|
Member |
|
|
On Tue, Feb 28, 2012 at 10:00 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Mon, 27 Feb 2012 14:58:47 -0800
> Suleiman Souhlal <ssouhlal@FreeBSD.org> wrote:
>
>> This is used to indicate that we don't want an allocation to be accounted
>> to the current cgroup.
>>
>> Signed-off-by: Suleiman Souhlal <suleiman@google.com>
>
> I don't like this.
>
> Please add
>
> ___GFP_ACCOUNT "account this allocation to memcg"
>
> Or make this as slab's flag if this work is for slab allocation.
We would like to account for all the slab allocations that happen in
process context.
Manually marking every single allocation or kmem_cache with a GFP flag
really doesn't seem like the right thing to do..
Can you explain why you don't like this flag?
-- Suleiman
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
