OpenVZ Forum: Devel » [PATCH 0/4] My contribution towards the end of populate()

Home » Mailing lists » Devel » [PATCH 0/4] My contribution towards the end of populate()

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 3/4] provide a function to register more cftype files into memcg [message #45599 is a reply to message #45588]

Wed, 21 March 2012 16:11

Tejun Heo
Messages: 184
Registered: November 2006

Senior Member

On Wed, Mar 21, 2012 at 11:27:12AM +0400, Glauber Costa wrote:
> >>+int mem_cgroup_register_cftype(const struct cftype *cfts)
> >>+{
> >>+ return WARN_ON(cgroup_add_cftypes(&mem_cgroup_subsys, cfts));
> >>+}
> >>+EXPORT_SYMBOL(mem_cgroup_register_cftype);
> >
> >Why not just export mem_cgroup_subsys?
> >
>
> I'm fine either way. I usually prefer not exporting raw data like
> this, but that's 100 % taste. How do you prefer me to do it?

I think exporting subsys directly is better than implementing thin
wrapper like above. IMHO, wrappers like above don't add any
functionality and are likely to just obfuscate what's going on.

Thanks.

--
tejun

Report message to a moderator

[Message index]

		[PATCH 0/4] My contribution towards the end of populate() By: Glauber Costa on Tue, 20 March 2012 16:50
		[PATCH 4/4] get rid of populate for memcg By: Glauber Costa on Tue, 20 March 2012 16:50
		Re: [PATCH 4/4] get rid of populate for memcg By: Tejun Heo on Tue, 20 March 2012 18:31
		Re: [PATCH 4/4] get rid of populate for memcg By: Glauber Costa on Wed, 21 March 2012 07:36
		Re: [PATCH 4/4] get rid of populate for memcg By: Tejun Heo on Wed, 21 March 2012 16:06
		Re: [PATCH 4/4] get rid of populate for memcg By: Tejun Heo on Wed, 21 March 2012 16:19
		Re: [PATCH 4/4] get rid of populate for memcg By: Glauber Costa on Wed, 21 March 2012 16:30
		[PATCH 3/4] provide a function to register more cftype files into memcg By: Glauber Costa on Tue, 20 March 2012 16:50
		Re: [PATCH 3/4] provide a function to register more cftype files into memcg By: Tejun Heo on Tue, 20 March 2012 18:32
		Re: [PATCH 3/4] provide a function to register more cftype files into memcg By: Glauber Costa on Wed, 21 March 2012 07:27
		Re: [PATCH 3/4] provide a function to register more cftype files into memcg By: Tejun Heo on Wed, 21 March 2012 16:11
		Re: [PATCH 3/4] provide a function to register more cftype files into memcg By: Glauber Costa on Wed, 21 March 2012 16:30
		[PATCH 2/4] pass struct mem_cgroup instead of struct cgroup to socket memcg By: Glauber Costa on Tue, 20 March 2012 16:50

Previous Topic:	[PATCH 1/4] don't trigger warning when d_subdirs is not empty.
Next Topic:	[PATCH v2 0/2] remove sock memcg dependencies on populate

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Feb 04 19:25:40 GMT 2026

Total time taken to generate the page: 0.73426 seconds