| Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF [message #45017 is a reply to message #45006] |
Fri, 20 January 2012 21:40   |
Myklebust, Trond
Messages: 52
Registered: November 2011
|
Member |
|
|
On Fri, 2012-01-20 at 16:55 +0400, Stanislav Kinsbursky wrote:
> This is a cleanup patch.
> Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
> socket flag is checked only for UDP sockets on receive.
> Thus (if I don't miss something non-obvious) this bit raising for temporary
> sockets can be removed.
>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>
> ---
> net/sunrpc/svcsock.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index e8af0c9..2867249 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
> spin_lock_bh(&serv->sv_lock);
> list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
> set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> - list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
> - set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> spin_unlock_bh(&serv->sv_lock);
> }
> EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
I'm assuming that Bruce will prefer to carry this, since it is
completely orthogonal to the net namespace patchsets.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
