OpenVZ Forum: Devel » [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls

Home » Mailing lists » Devel » [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v9 3/9] socket: initial cgroup code. [message #44716 is a reply to message #44501]

Thu, 22 December 2011 21:10

Jason Baron
Messages: 2
Registered: December 2011

Junior Member

On Mon, Dec 12, 2011 at 11:47:03AM +0400, Glauber Costa wrote:
> +
> +static bool mem_cgroup_is_root(struct mem_cgroup *memcg);
> +void sock_update_memcg(struct sock *sk)
> +{
> + /* A socket spends its whole life in the same cgroup */
> + if (sk->sk_cgrp) {
> + WARN_ON(1);
> + return;
> + }
> + if (static_branch(&memcg_socket_limit_enabled)) {
> + struct mem_cgroup *memcg;
> +
> + BUG_ON(!sk->sk_prot->proto_cgroup);
> +
> + rcu_read_lock();
> + memcg = mem_cgroup_from_task(current);
> + if (!mem_cgroup_is_root(memcg)) {
> + mem_cgroup_get(memcg);
> + sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg);
> + }
> + rcu_read_unlock();
> + }
> +}
> +EXPORT_SYMBOL(sock_update_memcg);
> +
> +void sock_release_memcg(struct sock *sk)
> +{
> + if (static_branch(&memcg_socket_limit_enabled) && sk->sk_cgrp) {
> + struct mem_cgroup *memcg;
> + WARN_ON(!sk->sk_cgrp->memcg);
> + memcg = sk->sk_cgrp->memcg;
> + mem_cgroup_put(memcg);
> + }
> +}

Hi Glauber,

I think for 'sock_release_memcg()', you want:

static inline sock_release_memcg(sk)
{
if (static_branch())
__sock_release_memcg();
}

And then re-define the current sock_release_memcg -> __sock_release_memcg().
In that way the straight line path is a single no-op. As currently
written, there is function call and then an immediate return.

Thanks,

-Jason

Report message to a moderator

[Message index]

		[PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Thu, 15 December 2011 12:29
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Fri, 16 December 2011 12:32
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Greg Thelen on Fri, 16 December 2011 06:20
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Fri, 16 December 2011 13:02
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Fri, 16 December 2011 13:30
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Wed, 14 December 2011 17:04
		[PATCH v9 2/9] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 4/9] tcp memory pressure controls By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 3/9] socket: initial cgroup code. By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 3/9] socket: initial cgroup code. By: Glauber Costa on Fri, 23 December 2011 08:57
		Re: [PATCH v9 3/9] socket: initial cgroup code. By: Jason Baron on Thu, 22 December 2011 21:10
		[PATCH v9 5/9] per-netns ipv4 sysctl_tcp_mem By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 7/9] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 6/9] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 8/9] Display current tcp failcnt in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 9/9] Display maximum tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Tue, 13 December 2011 00:07
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Christoph Paasch on Tue, 13 December 2011 13:49
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Eric Dumazet on Tue, 13 December 2011 13:59
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Tue, 13 December 2011 18:45
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Tue, 13 December 2011 20:11
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: KAMEZAWA Hiroyuki on Thu, 15 December 2011 05:40
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Thu, 15 December 2011 05:48
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Thu, 15 December 2011 06:48

Previous Topic:	[RFC] special case cpuacct cpuusage when cpu cgroup is comounted
Next Topic:	Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Apr 12 07:02:33 GMT 2026

Total time taken to generate the page: 0.64372 seconds