OpenVZ Forum: Devel » [PATCH] fdset's leakage

Home » Mailing lists » Devel » [PATCH] fdset's leakage

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] fdset's leakage [message #4471 is a reply to message #4457]

Tue, 11 July 2006 09:02

Rene Scharfe
Messages: 1
Registered: July 2006

Junior Member

[strange loop snipped]

> That's going to take a long time to compute if nr > NR_OPEN. I just fixed
> a similar infinite loop in this function.

That other fix looks buggy btw. Here it is:

- nfds = 8 * L1_CACHE_BYTES;
- /* Expand to the max in easy steps */
- while (nfds <= nr) {
- nfds = nfds * 2;
- if (nfds > NR_OPEN)
- nfds = NR_OPEN;
- }
+ nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nfds));
+ if (nfds > NR_OPEN)
+ nfds = NR_OPEN;

Surely you meant to say "roundup_pow_of_two(nr + 1)"?

Ren�

Report message to a moderator

[Message index]

		[PATCH] fdset's leakage By: Kirill Korotaev on Mon, 10 July 2006 13:40
		Re: [PATCH] fdset's leakage By: Andrew Morton on Tue, 11 July 2006 08:01
		Re: [PATCH] fdset's leakage By: Kirill Korotaev on Tue, 11 July 2006 09:05
		Re: [PATCH] fdset's leakage By: Andrew Morton on Tue, 11 July 2006 09:28
		Re: [PATCH] fdset's leakage By: Vadim Lobanov on Tue, 11 July 2006 16:13
		Re: [PATCH] fdset's leakage By: Eric Dumazet on Tue, 11 July 2006 17:26
		Re: [PATCH] fdset's leakage By: dev on Wed, 12 July 2006 10:49
		Re: [PATCH] fdset's leakage By: Rene Scharfe on Tue, 11 July 2006 09:02

Previous Topic:	[PATCH] struct file leakage
Next Topic:	Container Test Campaign

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 23 15:48:40 GMT 2025

Total time taken to generate the page: 0.06022 seconds