OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c
Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c [message #44708 is a reply to message #44704] Fri, 23 December 2011 13:39 Go to previous messageGo to previous message
Michal Hocko is currently offline  Michal Hocko
Messages: 109
Registered: December 2011
Senior Member
On Fri 23-12-11 14:08:09, Glauber Costa wrote:
> On 12/12/2011 01:31 PM, Glauber Costa wrote:
> >In commit a25cac5198 we changed the way we calculate idle and iowait
> >for /proc/stat displaying purposes. However, this same information
> >is also displayed in /proc/uptime. These values can now be inconsistent.
> >
> >So I propose we draw both idle values from the same place. In theory,
> >we only need to do it for get_idle_time(). get_iowait_time() is moved
> >as well for consistency only.
> >
> >I moved the functions to sched/core.c so it can live among its other
> >friends like nr_iowait(), etc.
> >
>
> You guys have any opinions on this ?
> I see that Michal got another fix for this in stat.c already, so I'd
> have to respin this one anyway. Just let me know if this is wanted

The last follow up fix is in Andrew's tree at the moment: procfs: do not
confuse jiffies with cputime64_t.

I don't mind moving those functions outside stat.c if it is reused.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls
Next Topic: [PATCH 1/3] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Fri Dec 19 14:06:47 GMT 2025

Total time taken to generate the page: 0.38539 seconds
Powered by FUDforum Powered by Virtuozzo Containers