OpenVZ Forum: Devel » [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls

Home » Mailing lists » Devel » [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls [message #44624 is a reply to message #44527]

Tue, 13 December 2011 13:49

Christoph Paasch
Messages: 1
Registered: December 2011

Junior Member

Hi,

On 12/13/2011 01:07 AM, David Miller wrote:
> From: Glauber Costa <glommer@parallels.com>
> Date: Mon, 12 Dec 2011 11:47:00 +0400
>
>> This series fixes all the few comments raised in the last round,
>> and seem to have acquired consensus from the memcg side.
>>
>> Dave, do you think it is acceptable now from the networking PoV?
>> In case positive, would you prefer merging this trough your tree,
>> or acking this so a cgroup maintainer can do it?
>
> All applied to net-next, thanks.

now there are plenty of compiler-warnings when CONFIG_CGROUPS is not set:

In file included from include/linux/tcp.h:211:0,
from include/linux/ipv6.h:221,
from include/net/ip_vs.h:23,
from kernel/sysctl_binary.c:6:
include/net/sock.h:67:57: warning: ‘struct cgroup_subsys’ declared
inside parameter list [enabled by default]
include/net/sock.h:67:57: warning: its scope is only this definition or
declaration, which is probably not what you want [enabled by default]
include/net/sock.h:67:57: warning: ‘struct cgroup’ declared inside
parameter list [enabled by default]
include/net/sock.h:68:61: warning: ‘struct cgroup_subsys’ declared
inside parameter list [enabled by default]
include/net/sock.h:68:61: warning: ‘struct cgroup’ declared inside
parameter list [enabled by default]

Because struct cgroup is only declared if CONFIG_CGROUPS is enabled.
(cfr. linux/cgroup.h)

Christoph

--
Christoph Paasch
PhD Student

IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://mptcp.info.ucl.ac.be
Université Catholique de Louvain
--

Report message to a moderator

[Message index]

		[PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Thu, 15 December 2011 12:29
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Fri, 16 December 2011 12:32
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Greg Thelen on Fri, 16 December 2011 06:20
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Fri, 16 December 2011 13:02
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Fri, 16 December 2011 13:30
		Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller By: Michal Hocko on Wed, 14 December 2011 17:04
		[PATCH v9 2/9] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 4/9] tcp memory pressure controls By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 3/9] socket: initial cgroup code. By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 3/9] socket: initial cgroup code. By: Glauber Costa on Fri, 23 December 2011 08:57
		Re: [PATCH v9 3/9] socket: initial cgroup code. By: Jason Baron on Thu, 22 December 2011 21:10
		[PATCH v9 5/9] per-netns ipv4 sysctl_tcp_mem By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 7/9] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 6/9] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 8/9] Display current tcp failcnt in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		[PATCH v9 9/9] Display maximum tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 12 December 2011 07:47
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Tue, 13 December 2011 00:07
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Christoph Paasch on Tue, 13 December 2011 13:49
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Eric Dumazet on Tue, 13 December 2011 13:59
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Tue, 13 December 2011 18:45
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Tue, 13 December 2011 20:11
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: KAMEZAWA Hiroyuki on Thu, 15 December 2011 05:40
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: davem on Thu, 15 December 2011 05:48
		Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls By: Glauber Costa on Thu, 15 December 2011 06:48

Previous Topic:	[RFC] special case cpuacct cpuusage when cpu cgroup is comounted
Next Topic:	Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Nov 04 01:52:49 GMT 2025

Total time taken to generate the page: 0.13942 seconds