| Re: [PATCH 2/7] perf: add ability to record event period [message #44602 is a reply to message #44257] |
Tue, 06 December 2011 14:02   |
![Arnaldo Carvalho de M[2] is currently offline](/theme/ovz3/images/offline.png "Arnaldo Carvalho de M[2] is currently offline")
Arnaldo Carvalho de M[2]
Messages: 17
Registered: November 2011
|
Junior Member |
|
|
Em Mon, Nov 28, 2011 at 12:03:30PM +0300, Andrew Vagin escreveu:
> Signed-off-by: Andrew Vagin <avagin@openvz.org>
> ---
> tools/perf/builtin-record.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
This patch doesn't apply in current tip/perf/core as this logic was
moved to perf_evsel/perf_evlist, so that it can be used by other tools.
Please add the 'period' variable to struct perf_record_opts and the
sample_type or'ing to perf_evsel__config().
I suggest you use https://github.com/acmel/linux/commits/perf/core for
that.
- Arnaldo
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 6ab58cc..e3b7fc4 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -62,6 +62,7 @@ static bool no_samples = false;
> static bool sample_address = false;
> static bool sample_time = false;
> static bool no_buildid = false;
> +static bool period = false;
> static bool no_buildid_cache = false;
> static struct perf_evlist *evsel_list;
>
> @@ -185,6 +186,9 @@ static void config_attr(struct perf_evsel *evsel, struct perf_evlist *evlist)
> if (evlist->nr_entries > 1)
> attr->sample_type |= PERF_SAMPLE_ID;
>
> + if (period)
> + attr->sample_type |= PERF_SAMPLE_PERIOD;
> +
> /*
> * We default some events to a 1 default interval. But keep
> * it a weak assumption overridable by the user.
> @@ -803,6 +807,7 @@ const struct option record_options[] = {
> OPT_BOOLEAN('d', "data", &sample_address,
> "Sample addresses"),
> OPT_BOOLEAN('T', "timestamp", &sample_time, "Sample timestamps"),
> + OPT_BOOLEAN('P', "period", &period, "Sample period"),
> OPT_BOOLEAN('n', "no-samples", &no_samples,
> "don't sample"),
> OPT_BOOLEAN('N', "no-buildid-cache", &no_buildid_cache,
> --
> 1.7.1
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
