OpenVZ Forum: Devel » [PATCH 00/11] SUNRPC: make sysctl per network namespcase context

Home » Mailing lists » Devel » [PATCH 00/11] SUNRPC: make sysctl per network namespcase context

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH 10/11] SUNRPC: allow debug flags modifications only from init_net [message #44558 is a reply to message #44548]

Wed, 14 December 2011 10:47

Stanislav Kinsbursky is currently offline

Stanislav Kinsbursky
Messages: 683
Registered: October 2011

Senior Member

Debug flags are global (i.e. fo all namespaces). So probably, it is better to
restrict write access and allow it only to processes with "init_net" network
namespace.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
net/sunrpc/sysctl.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
index eda80cf..224b075 100644
--- a/net/sunrpc/sysctl.c
+++ b/net/sunrpc/sysctl.c
@@ -156,7 +156,8 @@ proc_dodebug(ctl_table *table, int write,
return -EINVAL;
while (left && isspace(*s))
left--, s++;
- *(unsigned int *) table->data = value;
+ if (net_eq(current->nsproxy->net_ns, &init_net))
+ *(unsigned int *) table->data = value;
/* Display the RPC tasks on writing to rpc_debug */
if (strcmp(table->procname, "rpc_debug") == 0)
rpc_show_tasks(&init_net);

Report message to a moderator

[Message index]

		[PATCH 00/11] SUNRPC: make sysctl per network namespcase context By: Stanislav Kinsbursky on Wed, 14 December 2011 10:45
		[PATCH 11/11] SUNRPC: sysctl table for rpc_debug introduced By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Sat, 17 December 2011 22:25
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Mon, 19 December 2011 08:56
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Mon, 19 December 2011 10:14
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Mon, 19 December 2011 12:22
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Mon, 19 December 2011 16:37
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Mon, 19 December 2011 17:24
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Tue, 03 January 2012 03:48
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Tue, 10 January 2012 10:38
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Tue, 10 January 2012 22:38
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Wed, 11 January 2012 09:47
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Wed, 11 January 2012 17:20
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Wed, 11 January 2012 18:02
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: ebiederm on Wed, 11 January 2012 19:34
		Re: [PATCH 01/11] SYSCTL: export root and set handling routines By: Stanislav Kinsbursky on Thu, 12 January 2012 09:17
		[PATCH 02/11] SUNRPC: use syctl path instead of dummy parent table By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 03/11] SUNRPC: sysctl root for debug table introduced By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 05/11] SUNRPC: register debug sysctl table per network namespace By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 04/11] SUNRPC: per-net sysctl's set introduced By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 06/11] SUNRPC: register xs_tunables sysctl table per network namespace By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 07/11] SUNRPC: xs tunables per network namespace introduced By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 09/11] SUNRPC: remove xs_tcp_fin_timeout variable By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 10/11] SUNRPC: allow debug flags modifications only from init_net By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		[PATCH 08/11] SUNRPC: use per-net xs tunables instead of static ones By: Stanislav Kinsbursky on Wed, 14 December 2011 10:47
		Re: [PATCH 00/11] SUNRPC: make sysctl per network namespcase context By: Stanislav Kinsbursky on Tue, 07 February 2012 11:44
		Re: [PATCH 00/11] SUNRPC: make sysctl per network namespcase context By: Myklebust, Trond on Tue, 07 February 2012 13:21

Previous Topic:	[PATCH 1/5] make steal time's to-tick routine generic
Next Topic:	[PATCH 4/4] NFS: make nfs_client_lock per net ns

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 26 03:58:33 GMT 2025

Total time taken to generate the page: 0.09302 seconds