OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2/3] make clone_children a flag
Re: [PATCH 2/3] make clone_children a flag [message #44543 is a reply to message #44536] Wed, 14 December 2011 02:28 Go to previous messageGo to previous message
Li Zefan is currently offline  Li Zefan
Messages: 90
Registered: February 2008
Member
Tejun Heo wrote:
> On Sun, Dec 11, 2011 at 03:45:37PM +0100, Glauber Costa wrote:
>> There is no reason to have a flags field, and then a separate
>> bool field just to indicate if the clone_children flag is set.
>> Make it a flag
>>
>> Signed-off-by: Glauber Costa <glommer@parallels.com>
>
> Doesn't this change how remount conditions are checked?
>

Right. Currently we can do this:

# mount -t cgroup xxx /mnt
# mount -o remount,clone_children /mnt

with this patch, the above remount will fail.

But..the current bevaiour of remount is a bit confusing in that remount
with/without "clone_children" has no effect on anything:

# mount -t cgroup -o clone_children xxx /mnt
# cat /mnt/cgroup.clone_children
1
# mount -o remount xxx /mnt
# mount | grep cgroup
xxx on /mnt type cgroup (rw,clone_children)
# cat /mnt/cgroup.clone_children
1

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH v6 00/10] Request for inclusion: per-cgroup tcp memory pressure controls
Next Topic: [PATCH 1/7] SUNRPC: create rpcbind client in passed network namespace context
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Fri May 29 17:59:30 GMT 2026

Total time taken to generate the page: 0.38751 seconds
Powered by FUDforum Powered by Virtuozzo Containers