OpenVZ Forum: Devel » [PATCH 0/3] Simple cleanups for cgroups

Home » Mailing lists » Devel » [PATCH 0/3] Simple cleanups for cgroups

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 3/3] make 'none' field a flag [message #44542 is a reply to message #44538]

Wed, 14 December 2011 02:08

Li Zefan
Messages: 90
Registered: February 2008

Member

于 2011年12月13日 23:41, Tejun Heo 写道:
> On Sun, Dec 11, 2011 at 03:45:38PM +0100, Glauber Costa wrote:
>> There is no reason to have a flags field, and then a separate
>> bool field just to indicate if 'none' subsystem were explicitly
>> requested.
>>
>> Make it a flag
>>
>> Signed-off-by: Glauber Costa <glommer@parallels.com>
>
> Same as the previous patch. Doesn't this change how remount
> conditions are checked?
>

Right. The patch prevents us from doing:

# mount -t cgroup -o none,name=tmp xxx /mnt
# mount -o remount,cpuset xxx /mnt
(failed)

Report message to a moderator

[Message index]

		[PATCH 0/3] Simple cleanups for cgroups By: Glauber Costa on Sun, 11 December 2011 14:45
		[PATCH 3/3] make 'none' field a flag By: Glauber Costa on Sun, 11 December 2011 14:45
		Re: [PATCH 3/3] make 'none' field a flag By: Tejun Heo on Tue, 13 December 2011 15:41
		Re: [PATCH 3/3] make 'none' field a flag By: Li Zefan on Wed, 14 December 2011 02:08
		Re: [PATCH 3/3] make 'none' field a flag By: KOSAKI Motohiro on Sun, 11 December 2011 18:59

Previous Topic:	[PATCH 1/3] nitpick: make simple functions inline
Next Topic:	[PATCH v6 00/10] Request for inclusion: per-cgroup tcp memory pressure controls

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Feb 03 20:04:18 GMT 2026

Total time taken to generate the page: 1.25331 seconds