OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 1/3] nitpick: make simple functions inline
Re: [PATCH 1/3] nitpick: make simple functions inline [message #44490 is a reply to message #44481] Sun, 11 December 2011 20:44 Go to previous messageGo to previous message
Glauber Costa is currently offline  Glauber Costa
Messages: 916
Registered: October 2011
Senior Member
On 12/11/2011 07:55 PM, KOSAKI Motohiro wrote:
>> -static int notify_on_release(const struct cgroup *cgrp)
>> +static inline int notify_on_release(const struct cgroup *cgrp)
>> {
>> return test_bit(CGRP_NOTIFY_ON_RELEASE,&cgrp->flags);
>> }
>>
>> -static int clone_children(const struct cgroup *cgrp)
>> +static inline int clone_children(const struct cgroup *cgrp)
>> {
>> return test_bit(CGRP_CLONE_CHILDREN,&cgrp->flags);
>> }
>
> Can you please tell us which compiler failed automatic inlining?
> I suspect gcc is enough sane and we don't need this patch.

Of course we don't need, that's the very definition of a "nitpick".
This patch is directed towards the reader, not the compiler. Maintainers
are free to take it or not, although I believe being explicit is better.

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: [GIT PULL 0/3] perf/core fixes and improvements
Next Topic: [PATCH 0/3] Simple cleanups for cgroups
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Sat Apr 11 16:50:55 GMT 2026

Total time taken to generate the page: 0.56985 seconds
Powered by FUDforum Powered by Virtuozzo Containers