OpenVZ Forum: Devel » [PATCH v8 0/9] per-cgroup tcp memory pressure controls

Home » Mailing lists » Devel » [PATCH v8 0/9] per-cgroup tcp memory pressure controls

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller [message #44454 is a reply to message #44390]

Fri, 09 December 2011 01:21

KAMEZAWA Hiroyuki
Messages: 463
Registered: September 2006

Senior Member

On Mon, 5 Dec 2011 19:34:55 -0200
Glauber Costa <glommer@parallels.com> wrote:

> This patch lays down the foundation for the kernel memory component
> of the Memory Controller.
>
> As of today, I am only laying down the following files:
>
> * memory.independent_kmem_limit
> * memory.kmem.limit_in_bytes (currently ignored)
> * memory.kmem.usage_in_bytes (always zero)
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> Reviewed-by: Kirill A. Shutemov <kirill@shutemov.name>
> CC: Paul Menage <paul@paulmenage.org>
> CC: Greg Thelen <gthelen@google.com>

As I wrote, please CC Johannes and Michal Hocko for memcg related parts.

A few questions.
==
> + val = !!val;
> +
> + if (parent && parent->use_hierarchy &&
> + (val != parent->kmem_independent_accounting))
> + return -EINVAL;
==
Hm, why you check val != parent->kmem_independent_accounting ?

if (parent && parent->use_hierarchy)
return -EINVAL;
?

BTW, you didn't check this cgroup has children or not.
I think

if (this_cgroup->use_hierarchy &&
!list_empty(this_cgroup->childlen))
return -EINVAL;

==
> + /*
> + * TODO: We need to handle the case in which we are doing
> + * independent kmem accounting as authorized by our parent,
> + * but then our parent changes its parameter.
> + */
> + cgroup_lock();
> + memcg->kmem_independent_accounting = val;
> + cgroup_unlock();

Do we need cgroup_lock() here ?

Thanks,
-Kame

Report message to a moderator

[Message index]

		[PATCH v8 0/9] per-cgroup tcp memory pressure controls By: Glauber Costa on Mon, 05 December 2011 21:34
		[PATCH v8 2/9] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Mon, 05 December 2011 21:34
		Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling. By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:24
		Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Fri, 09 December 2011 12:41
		[PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Mon, 05 December 2011 21:34
		Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:21
		Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Fri, 09 December 2011 12:40
		Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Fri, 09 December 2011 14:37
		Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: KAMEZAWA Hiroyuki on Mon, 12 December 2011 00:34
		RE: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: David Laight on Fri, 09 December 2011 14:44
		Re: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller By: Glauber Costa on Fri, 09 December 2011 14:48
		[PATCH v8 3/9] socket: initial cgroup code. By: Glauber Costa on Mon, 05 December 2011 21:34
		Re: [PATCH v8 3/9] socket: initial cgroup code. By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:49
		Re: [PATCH v8 3/9] socket: initial cgroup code. By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 02:05
		Re: [PATCH v8 3/9] socket: initial cgroup code. By: Glauber Costa on Fri, 09 December 2011 12:43
		Re: [PATCH v8 3/9] socket: initial cgroup code. By: KAMEZAWA Hiroyuki on Mon, 12 December 2011 00:33
		[PATCH v8 5/9] per-netns ipv4 sysctl_tcp_mem By: Glauber Costa on Mon, 05 December 2011 21:34
		Re: [PATCH v8 5/9] per-netns ipv4 sysctl_tcp_mem By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:54
		[PATCH v8 6/9] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Mon, 05 December 2011 21:35
		Re: [PATCH v8 6/9] tcp buffer limitation: per-cgroup limit By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:55
		[PATCH v8 7/9] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 05 December 2011 21:35
		Re: [PATCH v8 7/9] Display current tcp memory allocation in kmem cgroup By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:56
		[PATCH v8 8/9] Display current tcp failcnt in kmem cgroup By: Glauber Costa on Mon, 05 December 2011 21:35
		[PATCH v8 9/9] Display maximum tcp memory allocation in kmem cgroup By: Glauber Costa on Mon, 05 December 2011 21:35
		Re: [PATCH v8 9/9] Display maximum tcp memory allocation in kmem cgroup By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:57
		[PATCH v8 4/9] tcp memory pressure controls By: Glauber Costa on Mon, 05 December 2011 21:34
		Re: [PATCH v8 4/9] tcp memory pressure controls By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:51
		Re: [PATCH v8 0/9] per-cgroup tcp memory pressure controls By: Glauber Costa on Wed, 07 December 2011 11:06
		Re: [PATCH v8 0/9] per-cgroup tcp memory pressure controls By: KAMEZAWA Hiroyuki on Fri, 09 December 2011 01:04

Previous Topic:	Re: [PATCH] make clone_children a flag
Next Topic:	How to draw values for /proc/stat

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jan 11 17:05:33 GMT 2026

Total time taken to generate the page: 0.80982 seconds