OpenVZ Forum: Devel » [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines

Home » Mailing lists » Devel » [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH 4/6] SUNRPC: remove RPC client pipefs dentries after unregister [message #44178 is a reply to message #44174]

Wed, 23 November 2011 11:05

Stanislav Kinsbursky is currently offline

Stanislav Kinsbursky
Messages: 683
Registered: October 2011

Senior Member

Without this patch we have races:

rpc_fill_super rpc_free_client
rpc_pipefs_event(MOUNT) rpc_remove_pipedir
spin_lock(&rpc_client_lock);
rpc_setup_pipedir_sb
spin_unlock(&rpc_client_lock);
spin_lock(&rpc_client_lock);
(remove from list)
spin_unlock(&rpc_client_lock);
MEAMORY LEAKED

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
net/sunrpc/clnt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 61c76ae..23776a4 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -572,7 +572,6 @@ rpc_free_client(struct rpc_clnt *clnt)
{
dprintk("RPC: destroying %s client for %s\n",
clnt->cl_protname, clnt->cl_server);
- rpc_clnt_remove_pipedir(clnt);
if (clnt->cl_parent != clnt) {
rpc_release_client(clnt->cl_parent);
goto out_free;
@@ -581,6 +580,7 @@ rpc_free_client(struct rpc_clnt *clnt)
kfree(clnt->cl_server);
out_free:
rpc_unregister_client(clnt);
+ rpc_clnt_remove_pipedir(clnt);
rpc_free_iostats(clnt->cl_metrics);
kfree(clnt->cl_principal);
clnt->cl_metrics = NULL;

Report message to a moderator

[Message index]

		[PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: Stanislav Kinsbursky on Wed, 23 November 2011 10:58
		[PATCH 1/6] SUNRPC: handle RPC client pipefs dentries by network namespace aware routines By: Stanislav Kinsbursky on Wed, 23 November 2011 11:02
		[PATCH 5/6] SUNRPC: remove RPC pipefs mount point manipulations from RPC clients code By: Stanislav Kinsbursky on Wed, 23 November 2011 11:04
		[PATCH 6/6] SUNRPC: remove RPC PipeFS mount point reference from RPC client By: Stanislav Kinsbursky on Wed, 23 November 2011 11:04
		[PATCH 4/6] SUNRPC: remove RPC client pipefs dentries after unregister By: Stanislav Kinsbursky on Wed, 23 November 2011 11:05
		[PATCH 3/6] SUNRPC: subscribe RPC clients to pipefs notifications By: Stanislav Kinsbursky on Wed, 23 November 2011 11:05
		[PATCH 2/6] SUNRPC: handle GSS AUTH pipes by network namespace aware routines By: Stanislav Kinsbursky on Wed, 23 November 2011 11:14
		Re: [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: bfields on Wed, 23 November 2011 16:27
		Re: [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: Stanislav Kinsbursky on Wed, 23 November 2011 17:18
		Re: [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: Stanislav Kinsbursky on Thu, 24 November 2011 08:45
		Re: [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: bfields on Wed, 23 November 2011 16:36
		Re: [PATCH 0/6] SUNRPC: make RPC clients use network-namespace-aware PipeFS routines By: Stanislav Kinsbursky on Wed, 23 November 2011 17:58

Previous Topic:	[PATCH v5 00/10] per-cgroup tcp memory pressure
Next Topic:	[PATCH 1/6] SUNRPC: split cache creation and PipeFS registration

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Feb 16 14:53:47 GMT 2026

Total time taken to generate the page: 0.36604 seconds