OpenVZ Forum: Devel » [PATCH] struct file leakage

Home » Mailing lists » Devel » [PATCH] struct file leakage

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] struct file leakage [message #4407]

Mon, 10 July 2006 09:05

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

Hello!

Andrew, this is a patch from Alexey Kuznetsov for 2.6.16.
I believe 2.6.17 still has this leak.

------------------------------------------------------------ -

2.6.16 leaks like hell. While testing, I found massive leakage
(reproduced in openvz) in:

*filp
*size-4096

And 1 object leaks in
*size-32
*size-64
*size-128

It is the fix for the first one. filp leaks in the bowels
of namei.c.

Seems, size-4096 is file table leaking in expand_fdtables.

I have no idea what are the rest and why they show only
accompaniing another leaks. Some debugging structs?

Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
CC: Kirill Korotaev <dev@openvz.org>

--- linux-2.6.16-w/fs/namei.c 2006-07-10 11:43:11.000000000 +0400
+++ linux-2.6.16/fs/namei.c 2006-07-10 11:53:36.000000000 +0400
@@ -1774,8 +1774,15 @@ do_link:
if (error)
goto exit_dput;
error = __do_follow_link(&path, nd);
- if (error)
+ if (error) {
+ /* Does someone understand code flow here? Or it is only
+ * me so stupid? Anathema to whoever designed this non-sense
+ * with "intent.open".
+ */
+ if (!IS_ERR(nd->intent.open.file))
+ release_open_intent(nd);
return error;
+ }
nd->flags &= ~LOOKUP_PARENT;
if (nd->last_type == LAST_BIND)
goto ok;

Report message to a moderator

[Message index]

		[PATCH] struct file leakage By: dev on Mon, 10 July 2006 09:05
		Re: [PATCH] struct file leakage By: Andrew Morton on Mon, 10 July 2006 10:05
		Re: [PATCH] struct file leakage By: Alexey Kuznetsov on Mon, 10 July 2006 10:16
		Re: [PATCH] struct file leakage By: Trond Myklebust on Tue, 11 July 2006 12:04
		Re: [PATCH] struct file leakage By: Andrew Morton on Tue, 11 July 2006 23:30
		Re: [PATCH] struct file leakage By: Trond Myklebust on Wed, 12 July 2006 00:26
		Re: [PATCH] struct file leakage By: ebiederm on Mon, 10 July 2006 11:56

Previous Topic:	vzquota do not build on s390 and powerpc
Next Topic:	[PATCH] fdset's leakage

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 26 14:04:17 GMT 2025

Total time taken to generate the page: 0.13168 seconds