OpenVZ Forum: Devel » [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame

Home » Mailing lists » Devel » [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() [message #43953 is a reply to message #43949]

Wed, 02 November 2011 19:31

Stephen Hemminger
Messages: 37
Registered: August 2006

Member

On Wed, 02 Nov 2011 23:08:57 +0400
Vasily Averin <vvs@parallels.com> wrote:

> if dst is not local br_handle_frame_finish() does not clone original skb and
> forgets to reset IPCB before return to IP stack. it can lead to stack corruption
> in icmp_send()
>
> Signed-off-by: Vasily Averin <vvs@sw.ru>
> ---
> net/bridge/br_input.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
> index f06ee39..6be8d00 100644
> --- a/net/bridge/br_input.c
> +++ b/net/bridge/br_input.c
> @@ -93,10 +93,11 @@ int br_handle_frame_finish(struct sk_buff *skb)
> skb2 = skb;
>
> br->dev->stats.multicast++;
> - } else if ((dst = __br_fdb_get(br, dest)) && dst->is_local) {
> + } else if ((dst = __br_fdb_get(br, dest)) != NULL) {
> skb2 = skb;
> /* Do not forward the packet since it's local. */
> - skb = NULL;
> + if (dst->is_local) {
> + skb = NULL;
> }
>
> if (skb) {

What kernel version are you using? There were several previous fixes
in br_netfilter to deal with this type of issue over the last year.

Report message to a moderator

[Message index]

		[PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() By: Vasily Averin on Wed, 02 November 2011 19:08
		Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() By: Vasily Averin on Wed, 02 November 2011 19:11
		Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() By: Stephen Hemminger on Wed, 02 November 2011 19:31
		Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() By: Vasily Averin on Wed, 02 November 2011 20:03
		Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() By: davem on Wed, 02 November 2011 20:09

Previous Topic:	[PATCH v2] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()
Next Topic:	Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Oct 09 03:00:42 GMT 2025

Total time taken to generate the page: 0.07985 seconds