OpenVZ Forum: Devel » [PATCH v6 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically

Home » Mailing lists » Devel » [PATCH v6 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction [message #43885 is a reply to message #43854]

Thu, 27 October 2011 21:30

bfields
Messages: 107
Registered: September 2007

Senior Member

On Tue, Oct 25, 2011 at 02:17:18PM +0300, Stanislav Kinsbursky wrote:
> svc_unregister() call have to be removed from svc_destroy() since it will be
> called in sv_shutdown callback.

It would be clearer that you're *moving* this if this were merged with
the following patch. And without doing that the series isn't quite
bisectable, unless I'm missing something.

--b.

>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>
> ---
> net/sunrpc/svc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 918edc3..407462f 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -530,7 +530,6 @@ svc_destroy(struct svc_serv *serv)
> if (svc_serv_is_pooled(serv))
> svc_pool_map_put();
>
> - svc_unregister(serv);
> kfree(serv->sv_pools);
> kfree(serv);
> }
>

Report message to a moderator

[Message index]

		[PATCH v6 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically By: Stanislav Kinsbursky on Tue, 25 October 2011 10:16
		[PATCH v6 3/8] SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		[PATCH v6 2/8] SUNRPC: use rpcbind reference counting helpers By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		[PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		Re: [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients By: Trond Myklebust on Tue, 25 October 2011 11:16
		Re: [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients By: Stanislav Kinsbursky on Tue, 25 October 2011 12:41
		Re: [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients By: Trond Myklebust on Tue, 25 October 2011 12:45
		Re: [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients By: Stanislav Kinsbursky on Tue, 25 October 2011 13:25
		[PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		Re: [PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it By: bfields on Thu, 27 October 2011 21:27
		Re: [PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it By: Stanislav Kinsbursky on Fri, 28 October 2011 09:27
		[PATCH v6 5/8] SUNRPC: cleanup service destruction By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction By: bfields on Thu, 27 October 2011 21:30
		Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction By: Stanislav Kinsbursky on Fri, 28 October 2011 09:49
		[PATCH v6 6/8] NFSd: call svc rpcbind cleanup explicitly By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		[PATCH v6 7/8] SUNRPC: remove rpcbind clients creation during service registering By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17
		[PATCH v6 8/8] SUNRPC: remove rpcbind clients destruction on module cleanup By: Stanislav Kinsbursky on Tue, 25 October 2011 10:17

Previous Topic:	[PATCH v2 1/4] SUNRPC: rpcbind clients internals virtualization
Next Topic:	[PATCH v7 0/7] SUNRPC: make rpcbind clients allocated and destroyed dynamically

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Oct 13 18:01:47 GMT 2025

Total time taken to generate the page: 0.17984 seconds