OpenVZ Forum: Devel » [PATCH v5 0/8] per-cgroup tcp buffer pressure settings

Home » Mailing lists » Devel » [PATCH v5 0/8] per-cgroup tcp buffer pressure settings

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v5 6/8] tcp buffer limitation: per-cgroup limit [message #43675 is a reply to message #43669]

Thu, 06 October 2011 08:38

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

On 10/05/2011 12:58 PM, Eric Dumazet wrote:
> Le mercredi 05 octobre 2011 à 12:08 +0400, Glauber Costa a écrit :
>> On 10/04/2011 04:48 PM, Eric Dumazet wrote:
>
>>> 2) Could you add const qualifiers when possible to your pointers ?
>>
>> Well, I'll go over the patches again and see where I can add them.
>> Any specific place site you're concerned about?
>
> Everywhere its possible :
>
> It helps reader to instantly knows if a function is about to change some
> part of the object or only read it, without reading function body.
Sure it does.

So, give me your opinion on this:

most of the acessors inside struct sock do not modify the pointers,
but return an address of an element inside it (that can later on be
modified by the caller.

I think it is fine for the purpose of clarity, but to avoid warnings we
end up having to do stuff like this:

+#define CONSTCG(m) ((struct mem_cgroup *)(m))
+long *tcp_sysctl_mem(const struct mem_cgroup *memcg)
+{
+ return CONSTCG(memcg)->tcp.tcp_prot_mem;
+}

Is it acceptable?

Report message to a moderator

[Message index]

		[PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 6/8] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Tue, 04 October 2011 12:17
		Re: [PATCH v5 6/8] tcp buffer limitation: per-cgroup limit By: Eric Dumazet on Tue, 04 October 2011 12:48
		Re: [PATCH v5 6/8] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Wed, 05 October 2011 08:08
		Re: [PATCH v5 6/8] tcp buffer limitation: per-cgroup limit By: Eric Dumazet on Wed, 05 October 2011 08:58
		Re: [PATCH v5 6/8] tcp buffer limitation: per-cgroup limit By: Glauber Costa on Thu, 06 October 2011 08:38
		[PATCH v5 3/8] foundations of per-cgroup memory pressure controlling. By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 7/8] Display current tcp memory allocation in kmem cgroup By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 2/8] socket: initial cgroup code. By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 5/8] per-netns ipv4 sysctl_tcp_mem By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 4/8] per-cgroup tcp buffers control By: Glauber Costa on Tue, 04 October 2011 12:17
		[PATCH v5 8/8] Disable task moving when using kernel memory accounting By: Glauber Costa on Tue, 04 October 2011 12:18
		Re: [PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: KAMEZAWA Hiroyuki on Wed, 05 October 2011 00:29
		Re: [PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: Glauber Costa on Wed, 05 October 2011 07:25
		Re: [PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: KAMEZAWA Hiroyuki on Fri, 07 October 2011 08:05
		Re: [PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: Glauber Costa on Fri, 07 October 2011 08:20
		Re: [PATCH v5 0/8] per-cgroup tcp buffer pressure settings By: KAMEZAWA Hiroyuki on Fri, 07 October 2011 08:55

Previous Topic:	Re: [PATCH 2/5] slab_id: Generic slab ID infrastructure
Next Topic:	[PATCH v6 0/8] per-cgroup tcp memory pressure handling

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jul 12 09:17:40 GMT 2026

Total time taken to generate the page: 0.38824 seconds