OpenVZ Forum: Devel » [PATCH 0/5] blk-throttle: writeback and swap IO control

Home » Mailing lists » Devel » [PATCH 0/5] blk-throttle: writeback and swap IO control

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages [message #41822 is a reply to message #41818]

Tue, 22 February 2011 19:12

Andrea Righi
Messages: 65
Registered: May 2008

Member

On Tue, Feb 22, 2011 at 10:42:41AM -0800, Chad Talbott wrote:
> On Tue, Feb 22, 2011 at 9:12 AM, Andrea Righi <arighi@develer.com> wrote:
> > Add the tracking of buffered (writeback) and anonymous pages.
> ...
> > ---
> > block/blk-throttle.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++-
> > include/linux/blkdev.h | 26 ++++++++++++++-
> > 2 files changed, 111 insertions(+), 2 deletions(-)
> >
> > diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> > index 9ad3d1e..a50ee04 100644
> > --- a/block/blk-throttle.c
> > +++ b/block/blk-throttle.c
> ...
> > +int blk_throtl_set_anonpage_owner(struct page *page, struct mm_struct *mm)
> > +int blk_throtl_set_filepage_owner(struct page *page, struct mm_struct *mm)
> > +int blk_throtl_copy_page_owner(struct page *npage, struct page *opage)
>
> It would be nice if these were named blk_cgroup_*. This is arguably
> more correct as the id comes from the blkio subsystem, and isn't
> specific to blk-throttle. This will be more important very shortly,
> as CFQ will be using this same cgroup id for async IO tracking soon.

Sounds reasonable. Will do in the next version.

>
> is_kernel_io() is a good idea, it avoids a bug that we've run into
> with CFQ async IO tracking. Why isn't PF_KTHREAD sufficient to cover
> all kernel threads, including kswapd and those marked PF_MEMALLOC?

With PF_MEMALLOC we're sure we don't add the page tracking overhead also
to non-kernel threads when memory gets low.

PF_KSWAPD is not probably needed, AFAICS it is only used by kswapd, that
is created by kthread_create() and so it has the PF_KTHREAD flag set.

Let's see if someone can give more deatils about that. In the while I'll
investigate and try to do some tests only with PF_KTHREAD.

Thanks,
-Andrea
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]

		[PATCH 0/5] blk-throttle: writeback and swap IO control By: Andrea Righi on Tue, 22 February 2011 17:12
		[PATCH 1/5] blk-cgroup: move blk-cgroup.h in include/linux/blk-cgroup.h By: Andrea Righi on Tue, 22 February 2011 17:12
		[PATCH 2/5] blk-cgroup: introduce task_to_blkio_cgroup() By: Andrea Righi on Tue, 22 February 2011 17:12
		[PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Tue, 22 February 2011 17:12
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Jonathan Corbet on Tue, 22 February 2011 20:01
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Vivek Goyal on Tue, 22 February 2011 21:57
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Tue, 22 February 2011 23:01
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Jonathan Corbet on Tue, 22 February 2011 23:27
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Tue, 22 February 2011 23:48
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Vivek Goyal on Tue, 22 February 2011 23:06
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Vivek Goyal on Tue, 22 February 2011 21:22
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Tue, 22 February 2011 23:08
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Jonathan Corbet on Tue, 22 February 2011 23:21
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Tue, 22 February 2011 23:37
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: KAMEZAWA Hiroyuki on Wed, 23 February 2011 04:49
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: Andrea Righi on Wed, 23 February 2011 08:59
		Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio By: KAMEZAWA Hiroyuki on Wed, 23 February 2011 23:58
		[PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Andrea Righi on Tue, 22 February 2011 17:12
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Andrea Righi on Tue, 22 February 2011 19:12
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Vivek Goyal on Tue, 22 February 2011 20:49
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Andrea Righi on Tue, 22 February 2011 23:03
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Vivek Goyal on Tue, 22 February 2011 21:00
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Andrea Righi on Tue, 22 February 2011 23:05
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Vivek Goyal on Wed, 23 February 2011 00:07
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Andrea Righi on Wed, 23 February 2011 08:37
		Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages By: Chad Talbott on Tue, 22 February 2011 18:42
		[PATCH 5/5] blk-throttle: buffered and anonymous page tracking instrumentation By: Andrea Righi on Tue, 22 February 2011 17:12
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Vivek Goyal on Tue, 22 February 2011 19:34
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Andrea Righi on Tue, 22 February 2011 22:41
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Vivek Goyal on Wed, 23 February 2011 00:03
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Andrea Righi on Wed, 23 February 2011 08:32
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Vivek Goyal on Wed, 23 February 2011 15:23
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Andrea Righi on Wed, 23 February 2011 23:14
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Vivek Goyal on Thu, 24 February 2011 00:10
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: KAMEZAWA Hiroyuki on Thu, 24 February 2011 00:40
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Greg Thelen on Thu, 24 February 2011 02:01
		Re: [PATCH 0/5] blk-throttle: writeback and swap IO control By: Balbir Singh on Thu, 24 February 2011 06:08

Previous Topic:	[PATCH 1/2] pidns: Don't allow new pids after the namespace is dead.
Next Topic:	userns: targeted capabilities v5

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 16 12:18:34 GMT 2025

Total time taken to generate the page: 0.35603 seconds