OpenVZ Forum: Devel » [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user

Home » Mailing lists » Devel » [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns [message #41807 is a reply to message #41806]

Mon, 21 February 2011 13:58

serge
Messages: 72
Registered: January 2007

Member

Quoting Oleg Nesterov (oleg@redhat.com):
> On 02/21, Daniel Lezcano wrote:
> >
> > On 02/21/2011 05:01 AM, Serge E. Hallyn wrote:
> >> To do so we need to pass in the task_struct who'll get the utsname,
> >> so we can get its user_ns.
> >>
> >> -extern struct uts_namespace *copy_utsname(unsigned long flags,
> >> - struct uts_namespace *ns);
> >> +extern struct uts_namespace *copy_utsname(struct task_struct *tsk,
> >> + unsigned long flags,
> >> + struct uts_namespace *ns);
> >
> > Why don't we pass 'user_ns' instead of 'tsk' ? that will look
> > semantically clearer for the caller no ?
> > (example below).
> > ...
> >
> > new_nsp->uts_ns = copy_utsname(flags, tsk->nsproxy->uts_ns, task_cred_xxx(tsk, user)->user_ns);
>
> To me tsk looks more readable, I mean
>
> new_nsp->uts_ns = copy_utsname(flags, tsk);
>
> copy_utsname() can find both uts_ns and user_ns looking at task_strcut.

Uh, yeah. I should remove the 'ns' argument there shouldn't I.

Daniel, does that sway your opinion then?

thanks,
-serge
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]

		[PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: serge on Mon, 21 February 2011 04:01
		[PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns By: serge on Mon, 21 February 2011 04:02
		Re: [PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns By: Daniel Lezcano on Mon, 21 February 2011 10:05
		[PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns By: serge on Thu, 24 February 2011 00:22
		Re: [PATCH 2/4] userns: let copy_ipcs handle setting ipc_ns->user_ns By: Daniel Lezcano on Thu, 24 February 2011 09:55
		[PATCH 3/4] Add the required user_ns parameter to security_capable By: serge on Mon, 21 February 2011 04:02
		[PATCH 4/4] userns: uts and ipc: fix checkpatch warning By: serge on Mon, 21 February 2011 04:05
		Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: Daniel Lezcano on Mon, 21 February 2011 10:03
		Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: Oleg Nesterov on Mon, 21 February 2011 13:41
		Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: serge on Mon, 21 February 2011 13:58
		Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: Daniel Lezcano on Mon, 21 February 2011 14:23
		[PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: serge on Thu, 24 February 2011 00:21
		Re: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns By: Daniel Lezcano on Thu, 24 February 2011 09:54
		[PATCH 5/4] Clean up capability.h and capability.c By: serge on Thu, 24 February 2011 00:22
		Re: [PATCH 5/4] Clean up capability.h and capability.c By: Daniel Lezcano on Thu, 24 February 2011 09:56

Previous Topic:	userns: targeted capabilities v5
Next Topic:	c/r:read pipe error when restart

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Jul 17 00:41:24 GMT 2024

Total time taken to generate the page: 0.02897 seconds