OpenVZ Forum: Devel » [PATCH, v6 0/3] Introduce timer slack controller

Home » Mailing lists » Devel » [PATCH, v6 0/3] Introduce timer slack controller

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller [message #41722 is a reply to message #41721]

Tue, 15 February 2011 06:04

Thomas Gleixner
Messages: 14
Registered: October 2007

Junior Member

On Tue, 15 Feb 2011, Kirill A. Shutemov wrote:
> On Mon, Feb 14, 2011 at 06:01:06PM +0100, Thomas Gleixner wrote:
> > > I think silent change here is wrong. cpuset returns -EBUSY in similar
> > > case.
> >
> > And how is cpuset relevant for this ? Not at all. This is about
> > timer_slack and we better have a well defined scheme for all of this
> > and not some cobbled together thing with tons of exceptions and corner
> > cases. Of course undocumented as far the code goes.
>
> I don't like silent cascade changes. Userspace can implement it if
> needed. -EBUSY is appropriate.

And I don't like totally uncommented code which follows come cobbled
together completely non obvious rules.

It's not about what you like. It's about getting useful functionality
when we add a new infrastructure like this.

So could you please explain what the rules of updating are, so that a
reviewer has a chance to understand the rationale of all this.

Thanks,

tglx

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]

		[PATCH, v6 0/3] Introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		[PATCH, v6 2/3] Implement timer slack notifier chain By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Thomas Gleixner on Mon, 14 February 2011 13:32
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Kirill A. Shutsemov on Mon, 14 February 2011 14:52
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Thomas Gleixner on Mon, 14 February 2011 15:16
		[PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Mon, 14 February 2011 13:59
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 22:59
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Tue, 15 February 2011 00:00
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Tue, 15 February 2011 00:10
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 14:00
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 15:19
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 17:01
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 22:39
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Tue, 15 February 2011 06:04
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Mon, 14 February 2011 23:39
		Re: [PATCH, v6 0/3] Introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 13:26

Previous Topic:	Re: [PATCH 1/1, v6] cgroup/freezer: add per freezer duty ratio control
Next Topic:	[PATCH 1/3] pid: Remove the child_reaper special case in init/main.c

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Oct 11 08:22:37 GMT 2025

Total time taken to generate the page: 0.23005 seconds