OpenVZ Forum: Devel » [PATCH, v6 0/3] Introduce timer slack controller

Home » Mailing lists » Devel » [PATCH, v6 0/3] Introduce timer slack controller

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH, v6 2/3] Implement timer slack notifier chain [message #41685 is a reply to message #41681]

Mon, 14 February 2011 14:52

Kirill A. Shutsemov is currently offline

Kirill A. Shutsemov
Messages: 32
Registered: February 2011

Member

On Mon, Feb 14, 2011 at 02:32:23PM +0100, Thomas Gleixner wrote:
> On Mon, 14 Feb 2011, Kirill A. Shutsemov wrote:
>
> > From: Kirill A. Shutemov <kirill@shutemov.name>
> >
> > Process can change its timer slack using prctl(). Timer slack notifier
> > call chain allows to react on such change or forbid it.
>
> So we add a notifier call chain and more exports to allow what ?

To allow the cgroup contoller validate the value.

> > --- a/kernel/sys.c
> > +++ b/kernel/sys.c
> > @@ -1691,15 +1691,10 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
> > error = perf_event_task_enable();
> > break;
> > case PR_GET_TIMERSLACK:
> > - error = current->timer_slack_ns;
> > + error = prctl_get_timer_slack();
>
> What's the point of replacing current->timer_slack_ns with a
> function which does exactly the same ?

To keep it consistent. BTW, prctl_get_seccomp() does the same.

>
> > +long prctl_set_timer_slack(long timer_slack_ns)
> > +{
> > + int err;
> > +
> > + /* Reset timer slack to default value */
> > + if (timer_slack_ns <= 0) {
> > + current->timer_slack_ns = current->default_timer_slack_ns;
> > + return 0;
>
> That does not make any sense at all. Why is setting
> default_timer_slack_ns not subject to validation ?

Hm.. In case of cgroup_timer_slack it's always valid.
But, yes, in general, we should validate it.

> Why is it treaded seperately ?

What do you mean?

> > + }
> > +
> > + err = blocking_notifier_call_chain(&timer_slack_notify_list,
> > + timer_slack_ns, NULL);
> > + if (err == NOTIFY_DONE)
> > + current->timer_slack_ns = timer_slack_ns;
> > +
> > + return notifier_to_errno(err);
>
> Thanks,
>
> tglx

--
Kirill A. Shutemov
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]

		[PATCH, v6 0/3] Introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		[PATCH, v6 2/3] Implement timer slack notifier chain By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Thomas Gleixner on Mon, 14 February 2011 13:32
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Kirill A. Shutsemov on Mon, 14 February 2011 14:52
		Re: [PATCH, v6 2/3] Implement timer slack notifier chain By: Thomas Gleixner on Mon, 14 February 2011 15:16
		[PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 13:06
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Mon, 14 February 2011 13:59
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 22:59
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Tue, 15 February 2011 00:00
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Tue, 15 February 2011 00:10
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 14:00
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 15:19
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 17:01
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Kirill A. Shutsemov on Mon, 14 February 2011 22:39
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Thomas Gleixner on Tue, 15 February 2011 06:04
		Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller By: Matt Helsley on Mon, 14 February 2011 23:39
		Re: [PATCH, v6 0/3] Introduce timer slack controller By: Thomas Gleixner on Mon, 14 February 2011 13:26

Previous Topic:	Re: [PATCH 1/1, v6] cgroup/freezer: add per freezer duty ratio control
Next Topic:	[PATCH 1/3] pid: Remove the child_reaper special case in init/main.c

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Aug 21 09:03:09 GMT 2025

Total time taken to generate the page: 0.05810 seconds