OpenVZ Forum: Devel » Re: [PATCH][usercr]: Ghost tasks must be detached

Home » Mailing lists » Devel » Re: [PATCH][usercr]: Ghost tasks must be detached

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH][usercr]: Ghost tasks must be detached [message #41600 is a reply to message #41593]

Wed, 09 February 2011 19:02

Sukadev Bhattiprolu is currently offline

Sukadev Bhattiprolu
Messages: 413
Registered: August 2006

Senior Member

Louis Rilling [Louis.Rilling@kerlabs.com] wrote:
| > | Are we still getting it with 2.6.37 ?
| >
| > I am not currently getting the crash on 2.6.37 - I thought it was due to
| > the following commit which removed the check for task_detached() in
| > do_wait_thread().
| >
| > commit 9cd80bbb07fcd6d4d037fad4297496d3b132ac6b
| > Author: Oleg Nesterov <oleg@redhat.com>
| > Date: Thu Dec 17 15:27:15 2009 -0800
|
| I don't think that this introduced the bug. The bug triggers with EXIT_DEAD
| tasks, for which wait() must ignore (see below). So, the bug looks still there
| in 2.6.37.

Sorry, I did not mean to imply that the above commit caused the crash
you saw in Jun 2010.

I can reproduce a crash with 2.6.32 - where if container-init terminates
before a detached child, we get a crash when the detached child calls
proc_flush_mnt(). I suspected it was because do_wait_thread() skipped
over detached tasks (in 2.6.32).

The same test case does not crash on 2.6.37 - which includes the above commit.
The removes the check for detached tasks, my initial guess is that the above
commit, may have contributed to _fixing_ the crash in 2.6.37.

Sukadev
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs

Report message to a moderator

[Message index]

		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Sat, 05 February 2011 18:55
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Sat, 05 February 2011 21:40
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Sat, 05 February 2011 22:02
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Sat, 05 February 2011 22:33
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Wed, 09 February 2011 02:09
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Wed, 09 February 2011 03:35
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Thu, 10 February 2011 02:44
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Thu, 10 February 2011 03:53
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Thu, 10 February 2011 06:17
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Thu, 10 February 2011 14:56
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Thu, 10 February 2011 17:42
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Wed, 16 February 2011 20:10
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Thu, 17 February 2011 15:21
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Mon, 21 February 2011 20:40
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Tue, 22 February 2011 10:28
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Wed, 09 February 2011 12:01
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Oren Laadan on Wed, 09 February 2011 12:18
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Wed, 09 February 2011 12:35
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Wed, 09 February 2011 12:37
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Wed, 09 February 2011 19:02
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Thu, 10 February 2011 10:23
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Thu, 10 February 2011 17:54
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Louis Rilling on Thu, 10 February 2011 18:04
		Re: [PATCH][usercr]: Ghost tasks must be detached By: Sukadev Bhattiprolu on Thu, 10 February 2011 22:31

Previous Topic:	[PATCH] Reduce uidhash lock hold time when lookup succeeds
Next Topic:	[PATCH] Don't crash if we are self-checkpointing with a child

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Nov 28 05:34:08 GMT 2025

Total time taken to generate the page: 0.45048 seconds