OpenVZ Forum: Devel » [PATCH 1/3] proc: sysctl: rename proc_doutsstring to proc_do_uts

Home » Mailing lists » Devel » [PATCH 1/3] proc: sysctl: rename proc_doutsstring to proc_do_uts_string

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 3/3] proc: make UTS-related sysctls utsns aware [message #3374 is a reply to message #3356]

Wed, 24 May 2006 18:02

Dave Hansen
Messages: 240
Registered: October 2005

Senior Member

On Tue, 2006-05-23 at 13:23 +1200, Sam Vilain wrote:
>
> + /* map the filename to the pointer. perhaps it would be
> better
> + to put struct offset pointers in table->data ? */
> + switch (filp->f_dentry->d_name.name[3]) {
> + case 'y': /* ostYpe */
> + which = uts_ns->name.sysname;
> + break;
> + case 't': /* hosTname */
> + which = uts_ns->name.nodename;
> + break;
> + case 'e': /* osrElease */
> + which = uts_ns->name.release;
> + break;
> + case 's': /* verSion */
> + which = uts_ns->name.version;
> + break;
> + case 'x': /* XXX - unreachable */
> + which = uts_ns->name.machine;
> + break;
> + case 'a': /* domAinname */
> + which = uts_ns->name.domainname;
> + break;
> + default:
> + printk("procfs: impossible uts part '%s'",
> + (char*)filp->f_dentry->d_name.name);
> + r = -EINVAL;
> + goto out;
> + }

Why not just switch on the ->ctl_name from the table? Wouldn't that be
easier?

-- Dave

Report message to a moderator

[Message index]

		[PATCH 1/3] proc: sysctl: rename proc_doutsstring to proc_do_uts_string By: Sam Vilain on Tue, 23 May 2006 01:23
		[PATCH 2/3] proc: sysctl: add _proc_do_string helper By: Sam Vilain on Tue, 23 May 2006 01:23
		[PATCH 3/3] proc: make UTS-related sysctls utsns aware By: Sam Vilain on Tue, 23 May 2006 01:23
		Re: [PATCH 3/3] proc: make UTS-related sysctls utsns aware By: Andrew Morton on Wed, 24 May 2006 15:54
		Re: [PATCH 3/3] proc: make UTS-related sysctls utsns aware By: Sam Vilain on Thu, 25 May 2006 03:51
		Re: [PATCH 3/3] proc: make UTS-related sysctls utsns aware By: Dave Hansen on Wed, 24 May 2006 18:02
		Re: [PATCH 3/3] proc: make UTS-related sysctls utsns aware By: Sam Vilain on Thu, 25 May 2006 04:01

Previous Topic:	[PATCH] namespaces: uts_ns: make information visible via /proc/PID/uts directory
Next Topic:	Beta openvz kernel compile error

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Aug 14 23:57:36 GMT 2024

Total time taken to generate the page: 0.02685 seconds