OpenVZ Forum: Devel » [PATCH 0/9] namespaces: Introduction

Home » Mailing lists » Devel » [PATCH 0/9] namespaces: Introduction

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces [message #3325 is a reply to message #3250]

Mon, 22 May 2006 20:16

rdunlap
Messages: 11
Registered: May 2006

Junior Member

On Mon, 22 May 2006 21:43:37 +0200 Cedric Le Goater wrote:

> Randy.Dunlap wrote:
> >>
> >> 9ee063adf4d2287583dbb0a71d1d5f80d7ae011f
> >> diff --git a/arch/i386/kernel/sys_i386.c b/arch/i386/kernel/sys_i386.c
> >> index 8fdb1fb..4af731d 100644
> >> --- a/arch/i386/kernel/sys_i386.c
> >> +++ b/arch/i386/kernel/sys_i386.c
> >> @@ -210,7 +210,7 @@ asmlinkage int sys_uname(struct old_utsn
> >> if (!name)
> >> return -EFAULT;
> >> down_read(&uts_sem);
> >> - err=copy_to_user(name, &system_utsname, sizeof (*name));
> >> + err=copy_to_user(name, utsname(), sizeof (*name));
> >
> > It would be really nice if you would fix spacing while you are here,
> > like a space a each side of '='.
> >
> > and a space after ',' in the function calls below.
>
> Here's a possible cleanup on top of serge's patchset as found in
> 2.6.17-rc4-mm3.

Yes, thanks, looks good.

---
~Randy

Report message to a moderator

[Message index]

		[PATCH 0/9] namespaces: Introduction By: serue on Thu, 18 May 2006 15:47
		[PATCH 7/9] namespaces: utsname: sysctl hack By: serue on Thu, 18 May 2006 15:50
		[PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: serue on Thu, 18 May 2006 15:49
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 00:02
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: serue on Fri, 19 May 2006 02:21
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 02:42
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: ebiederm on Fri, 19 May 2006 09:05
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 17:37
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: ebiederm on Fri, 19 May 2006 11:58
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: Cedric Le Goater on Mon, 22 May 2006 19:43
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: Sam Vilain on Mon, 22 May 2006 00:19
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Mon, 22 May 2006 20:16
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Fri, 19 May 2006 08:50
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Fri, 19 May 2006 13:30
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Sun, 21 May 2006 16:27
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Sun, 21 May 2006 18:08
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Mon, 22 May 2006 12:10
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Mon, 22 May 2006 16:44
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Fri, 19 May 2006 19:38
		Re: [PATCH 0/9] namespaces: Introduction By: John Kelly on Fri, 19 May 2006 19:45
		Re: [PATCH 0/9] namespaces: Introduction By: John Kelly on Fri, 19 May 2006 20:23
		Re: [PATCH 0/9] namespaces: Introduction By: Alexey Kuznetsov on Fri, 19 May 2006 20:52
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Sun, 21 May 2006 23:18
		Re: [PATCH 0/9] namespaces: Introduction By: Herbert Poetzl on Sun, 21 May 2006 23:32
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Mon, 22 May 2006 16:54

Previous Topic:	Re: [PATCH 0/9] namespaces: Introduction
Next Topic:	[PATCH] namespaces: uts_ns: make information visible via /proc/PID/uts directory

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jul 13 11:44:22 GMT 2025

Total time taken to generate the page: 0.01923 seconds