OpenVZ Forum: Devel » [PATCH 1/9] namespaces: add nsproxy

Home » Mailing lists » Devel » [PATCH 1/9] namespaces: add nsproxy

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/9] namespaces: add nsproxy [message #3301 is a reply to message #3299]

Sun, 21 May 2006 23:38

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Sam Vilain <sam@vilain.net> writes:

> Serge E. Hallyn wrote:
>
>>@@ -1585,7 +1591,15 @@ asmlinkage long sys_unshare(unsigned lon
>>
>> if (new_fs || new_ns || new_sigh || new_mm || new_fd || new_ulist) {
>>
>>+ old_nsproxy = current->nsproxy;
>>+ new_nsproxy = dup_namespaces(old_nsproxy);
>>+ if (!new_nsproxy) {
>>+ err = -ENOMEM;
>>+ goto bad_unshare_cleanup_semundo;
>>+ }
>>+
>> task_lock(current);
>>
>>
>
> We'll get lots of duplicate nsproxy structures before we move all of the
> pointers for those subsystems into it. Do we need to dup namespaces on
> all of those conditions?

Ugh. Good catch. The new nsproxy needs to be just for the fs and the uts
namespace.

I guess that means that test should be moved up a few lines.

Eric

Report message to a moderator

[Message index]

		[PATCH 1/9] namespaces: add nsproxy By: serue on Thu, 18 May 2006 15:48
		Re: [PATCH 1/9] namespaces: add nsproxy By: Sam Vilain on Sun, 21 May 2006 23:30
		Re: [PATCH 1/9] namespaces: add nsproxy By: ebiederm on Sun, 21 May 2006 23:38
		Re: [PATCH 1/9] namespaces: add nsproxy By: serue on Mon, 22 May 2006 12:39

Previous Topic:	[Fwd: [PATCH 1/1] scsi : megaraid_{mm, mbox}: a fix on 64-bit DMA capability check]
Next Topic:	Re: [PATCH 0/9] namespaces: Introduction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat May 23 20:32:25 GMT 2026

Total time taken to generate the page: 0.37777 seconds