OpenVZ Forum: Devel » [PATCH 0/9] namespaces: Introduction

Home » Mailing lists » Devel » [PATCH 0/9] namespaces: Introduction

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces [message #3266 is a reply to message #3257]

Fri, 19 May 2006 11:58

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

"Randy.Dunlap" <rdunlap@xenotime.net> writes:

> OK, here's my big comment/question. I want to see <nodename> increased to
> 256 bytes (per current POSIX), so each field of struct <variant>_utsname
> needs be copied individually (I think) instead of doing a single
> struct copy.
>
> I've been working on this for the past few weeks (among other
> things). Sorry about the timing.
> I could send patches for this against mainline in a few days,
> but I'll be glad to listen to how it would be easiest for all of us
> to handle.
>
> I'm probably a little over half done with my patches.
> They will end up adding a lib/utsname.c that has functions for:
> put_oldold_unmame() // to user
> put_old_uname() // to user
> put_new_uname() // to user
> put_posix_uname() // to user

Looking 256 at least makes sense to hold a dns fully qualified domain
name. So even if it isn't specified by posix is make sense.

Can we please make the structure we return to user space look something
like:

struct long_utsname {
char *sysname;
char *nodename;
char *release;
char *version;
char *machine;
char *domainname;
char buf[0];
}

int sys_long_uname(char *buf, size_t bufsz);

So we don't hard code the maximum length of these strings into the user
interface, and can just return more by increasing our buffer size.

Eric

Report message to a moderator

[Message index]

		[PATCH 0/9] namespaces: Introduction By: serue on Thu, 18 May 2006 15:47
		[PATCH 7/9] namespaces: utsname: sysctl hack By: serue on Thu, 18 May 2006 15:50
		[PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: serue on Thu, 18 May 2006 15:49
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 00:02
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: serue on Fri, 19 May 2006 02:21
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 02:42
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: ebiederm on Fri, 19 May 2006 09:05
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Fri, 19 May 2006 17:37
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: ebiederm on Fri, 19 May 2006 11:58
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: Cedric Le Goater on Mon, 22 May 2006 19:43
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: Sam Vilain on Mon, 22 May 2006 00:19
		Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces By: rdunlap on Mon, 22 May 2006 20:16
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Fri, 19 May 2006 08:50
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Fri, 19 May 2006 13:30
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Sun, 21 May 2006 16:27
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Sun, 21 May 2006 18:08
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Mon, 22 May 2006 12:10
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Mon, 22 May 2006 16:44
		Re: [PATCH 0/9] namespaces: Introduction By: serue on Fri, 19 May 2006 19:38
		Re: [PATCH 0/9] namespaces: Introduction By: John Kelly on Fri, 19 May 2006 19:45
		Re: [PATCH 0/9] namespaces: Introduction By: John Kelly on Fri, 19 May 2006 20:23
		Re: [PATCH 0/9] namespaces: Introduction By: Alexey Kuznetsov on Fri, 19 May 2006 20:52
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Sun, 21 May 2006 23:18
		Re: [PATCH 0/9] namespaces: Introduction By: Herbert Poetzl on Sun, 21 May 2006 23:32
		Re: [PATCH 0/9] namespaces: Introduction By: ebiederm on Mon, 22 May 2006 16:54

Previous Topic:	Re: [PATCH 0/9] namespaces: Introduction
Next Topic:	[PATCH] namespaces: uts_ns: make information visible via /proc/PID/uts directory

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Aug 15 05:29:14 GMT 2024

Total time taken to generate the page: 0.02693 seconds