OpenVZ Forum


Home » Mailing lists » Devel » sysfs : fix kobject rename with multiple namespaces
Re: sysfs : fix kobject rename with multiple namespaces [message #30014 is a reply to message #30013] Mon, 05 May 2008 17:05 Go to previous message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
Serge E. Hallyn wrote:
  > The patch looks good to me, except I'd really rename this to
> 'sysfs_tag_eq'.  Calling it 'cmp', returning 't1!=t2', then checking for
> !sysfs_tag_cmp really increases the amount of thinking i have to do to
> make sure everything is koshepillager :)
> 
> Maybe it's just me.

I just wanted to have sysfs_tag_cmp returning zero when sysfs is 
disabled in order to be consistent with other functions.

But if that hurts, I can change that to something more mindless.

Thanks for looking at the patch.

   -- Daniel
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Previous Topic: Re: [PATCH 10/10] sysfs: user namespaces: add ns to user_struct
Next Topic: [PATCH 1/8] Scaling msgmni to the amount of lowmem
Goto Forum:
  


Current Time: Thu Nov 13 12:43:42 GMT 2025

Total time taken to generate the page: 0.10480 seconds