OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).
Re: [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2). [message #28682 is a reply to message #28681] Wed, 26 March 2008 09:27 Go to previous messageGo to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Wed, 26 Mar 2008 12:25:40 +0300

> Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
> relookup support) introduced some dst leaks on error paths: the rt
> pointer can be forgotten to be put. Fix it bu going to a proper label.
> 
> Found after net namespace's lo refused to unregister :) Many thanks to 
> Den for valuable help during debugging.
> 
> Herbert pointed out, that xfrm_lookup() will put the rtable in case
> of error itself, so the first goto fix is redundant.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Looks good, applied, thanks!
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: reminder about containers mini-summit at ols
Next Topic: [PATCH 0/3 net-2.6.26] Compilation fixes.
Goto Forum:
  


Current Time: Sun Jul 27 16:23:44 GMT 2025

Total time taken to generate the page: 0.69705 seconds