OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] Don't create tunnels with '%' in name.
Re: [PATCH] Don't limit the number of tunnels with generic name explicitly. [message #27639 is a reply to message #27637] Thu, 21 February 2008 12:45 Go to previous messageGo to previous message
Patrick McHardy is currently offline  Patrick McHardy
Messages: 107
Registered: March 2006
Senior Member
Pavel Emelyanov wrote:
> Patrick McHardy wrote:
>> Pavel Emelyanov wrote:
>>> Patrick McHardy wrote:
>>>
>>>> It would be nicer to replace the entire hand-made name
>>>> allocation to remove the 100 device limit.
>>>>
>>> Actually, I thought the same, but fixing % in names looks like a 
>>> BUG-fix for 2.6.25, while removing the hand-made name allocation 
>>> looks like an enhancement for 2.6.26. No?
>>
>> Well, its so closely related that I guess it would still look
>> like a bugfix :) But changing this in 2.6.26 is also fine of
>> course, your patch just reminded me since I wanted to change
>> this for a long time and repeatedly forgot about it again.
> 
> Ok, point taken ;) Here's the 2nd patch that does so. If David 
> decides it can go to 2.6.25, that would be good, otherwise this 
> patch will fit the 2.6.26 as well.
> 
> Changelog:
> 
> Use the added dev_alloc_name() call to create tunnel device name,
> rather than iterate in a hand-made loop with an artificial limit.
> 
> Thanks Patrick for noticing this.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>


Looks good to me, thanks.
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] pidns: make pid->level and pid_ns->level unsigned
Next Topic: [PATCH 00/10] CGroup API files: Various cleanup to CGroup control files
Goto Forum:
  


Current Time: Tue Jul 22 07:16:20 GMT 2025

Total time taken to generate the page: 0.12206 seconds