| Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack [message #2759 is a reply to message #2754] |
Wed, 19 April 2006 17:10   |
serue
Messages: 750
Registered: February 2006
|
Senior Member |
|
|
Quoting Kirill Korotaev (dev@sw.ru):
> Serge,
>
> >Please look closer at the patch.
> >I *am* doing nothing with sysctls.
> >
> >system_utsname no longer exists, and the way to get to that is by using
> >init_uts_ns.name. That's all this does.
> Sorry for being not concrete enough.
> I mean switch () in the code. Until we decided how to virtualize
> sysctls/proc, I believe no dead code/hacks should be commited. IMHO.
>
> FYI, I strongly object against virtualizing sysctls this way as it is
> not flexible and is a real hack from my POV.
Oops, I forgot that was there!
Sorry.
Yup, I'm fine with leaving that out. After all, nothing in the
non-debugging patchset allows userspace to clone the utsnamespace yet,
so it's tough to argue that leaving out that switch impacts
functionality :)
I believe Dave is working on a more acceptable sysctl adaptation, though
I'm not sure when he'll have a patch to submit. In any case, one clear
concise piece at a time.
thanks,
-serge
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
