Home » Mailing lists » Devel » [RFC][PATCH 4/5] utsname namespaces: sysctl hack
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack [message #2754 is a reply to message #2751] |
Wed, 19 April 2006 15:43 ![Go to previous message Go to previous message](/theme/ovz3/images/up.png) ![Go to next message Go to previous message](/theme/ovz3/images/down.png) |
dev
Messages: 1693 Registered: September 2005 Location: Moscow
|
Senior Member |
![5072133](/theme/ovz3/images/icq.png)
|
|
Serge,
> Please look closer at the patch.
> I *am* doing nothing with sysctls.
>
> system_utsname no longer exists, and the way to get to that is by using
> init_uts_ns.name. That's all this does.
Sorry for being not concrete enough.
I mean switch () in the code. Until we decided how to virtualize
sysctls/proc, I believe no dead code/hacks should be commited. IMHO.
FYI, I strongly object against virtualizing sysctls this way as it is
not flexible and is a real hack from my POV.
Sure, change of system_utsname.sysname -> init_uts_ns.name.sysname is Ok.
Thanks,
Kirill
>>>Sysctl uts patch. This clearly will need to be done another way, but
>>>since sysctl itself needs to be container aware, 'the right thing' is
>>>a separate patchset.
>>>
>>>Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
>>>---
>>>kernel/sysctl.c | 38 ++++++++++++++++++++++++++++----------
>>>1 files changed, 28 insertions(+), 10 deletions(-)
>>>
>>>40f7e1320c82efb6e875fc3bf44408cdfd093f21
>>>diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>>>index e82726f..c2b18ef 100644
>>>--- a/kernel/sysctl.c
>>>+++ b/kernel/sysctl.c
>>>@@ -233,8 +233,8 @@ static ctl_table kern_table[] = {
>>> {
>>> .ctl_name = KERN_OSTYPE,
>>> .procname = "ostype",
>>>- .data = system_utsname.sysname,
>>>- .maxlen = sizeof(system_utsname.sysname),
>>>+ .data = init_uts_ns.name.sysname,
>>>+ .maxlen = sizeof(init_uts_ns.name.sysname),
>>> .mode = 0444,
>>> .proc_handler = &proc_doutsstring,
>>> .strategy = &sysctl_string,
>>>@@ -242,8 +242,8 @@ static ctl_table kern_table[] = {
>>> {
>>> .ctl_name = KERN_OSRELEASE,
>>> .procname = "osrelease",
>>>- .data = system_utsname.release,
>>>- .maxlen = sizeof(system_utsname.release),
>>>+ .data = init_uts_ns.name.release,
>>>+ .maxlen = sizeof(init_uts_ns.name.release),
>>> .mode = 0444,
>>> .proc_handler = &proc_doutsstring,
>>> .strategy = &sysctl_string,
>>>@@ -251,8 +251,8 @@ static ctl_table kern_table[] = {
>>> {
>>> .ctl_name = KERN_VERSION,
>>> .procname = "version",
>>>- .data = system_utsname.version,
>>>- .maxlen = sizeof(system_utsname.version),
>>>+ .data = init_uts_ns.name.version,
>>>+ .maxlen = sizeof(init_uts_ns.name.version),
>>> .mode = 0444,
>>> .proc_handler = &proc_doutsstring,
>>> .strategy = &sysctl_string,
>>>@@ -260,8 +260,8 @@ static ctl_table kern_table[] = {
>>> {
>>> .ctl_name = KERN_NODENAME,
>>> .procname = "hostname",
>>>- .data = system_utsname.nodename,
>>>- .maxlen = sizeof(system_utsname.nodename),
>>>+ .data = init_uts_ns.name.nodename,
>>>+ .maxlen = sizeof(init_uts_ns.name.nodename),
>>> .mode = 0644,
>>> .proc_handler = &proc_doutsstring,
>>> .strategy = &sysctl_string,
>>>@@ -269,8 +269,8 @@ static ctl_table kern_table[] = {
>>> {
>>> .ctl_name = KERN_DOMAINNAME,
>>> .procname = "domainname",
>>>- .data = system_utsname.domainname,
>>>- .maxlen = sizeof(system_utsname.domainname),
>>>+ .data = init_uts_ns.name.domainname,
>>>+ .maxlen = sizeof(init_uts_ns.name.domainname),
>>> .mode = 0644,
>>> .proc_handler = &proc_doutsstring,
>>> .strategy = &sysctl_string,
>>>@@ -1619,6 +1619,24 @@ static int proc_doutsstring(ctl_table *t
>>>{
>>> int r;
>>>
>>>+ switch (table->ctl_name) {
>>>+ case KERN_OSTYPE:
>>>+ table->data = utsname()->sysname;
>>>+ break;
>>>+ case KERN_OSRELEASE:
>>>+ table->data = utsname()->release;
>>>+ break;
>>>+ case KERN_VERSION:
>>>+ table->data = utsname()->version;
>>>+ break;
>>>+ case KERN_NODENAME:
>>>+ table->data = utsname()->nodename;
>>>+ break;
>>>+ case KERN_DOMAINNAME:
>>>+ table->data = utsname()->domainname;
>>>+ break;
>>>+ }
>>>+
>>> if (!write) {
>>> down_read(&uts_sem);
>>> r=proc_dostring(table,0,filp,buffer,lenp, ppos);
>>
>
|
|
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
[RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Fri, 07 April 2006 18:36
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: dev on Wed, 19 April 2006 15:10
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Wed, 19 April 2006 15:21
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: dev on Wed, 19 April 2006 15:43
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 17:10
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Wed, 19 April 2006 17:10
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 15:52
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 16:52
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 17:37
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 17:48
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 15:29
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Wed, 19 April 2006 17:51
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: ebiederm on Wed, 19 April 2006 18:27
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Wed, 19 April 2006 20:24
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Thu, 20 April 2006 17:05
|
![Read Message Read Message](/theme/ovz3/images/read.png) |
|
Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack
By: serue on Tue, 25 April 2006 22:00
|
Goto Forum:
Current Time: Tue Aug 13 15:33:23 GMT 2024
Total time taken to generate the page: 0.02748 seconds
|