OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() [message #27433 is a reply to message #27431] Mon, 18 February 2008 06:22 Go to previous messageGo to previous message
yamamoto is currently offline  yamamoto
Messages: 97
Registered: July 2007
Member
> Li Zefan wrote:
> > No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
> > be VM_BUG_ON(page).
> > 
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
> pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not sure
> why we can't bug on pc.

pc is dereferenced before this VM_BUG_ON.

YAMAMOTO Takashi

> 
> 
> 
> -- 
> 	Warm Regards,
> 	Balbir Singh
> 	Linux Technology Center
> 	IBM, ISTL
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Next Topic: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Goto Forum:
  


Current Time: Thu Aug 28 05:02:39 GMT 2025

Total time taken to generate the page: 0.11176 seconds