OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h. [message #25041 is a reply to message #25040] Thu, 13 December 2007 14:49 Go to previous messageGo to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Alexey Dobriyan <adobriyan@sw.ru>
Date: Thu, 13 Dec 2007 17:47:07 +0300

> On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> > There are to many spaces between type and function name in the declaration
> > of fib rules manipulation routines. Eat them and save a couple of lines.
> 
> If this patch is going in, it would be nice to get rid of "extern" as
> well.

The convention in the networking headers is to use extern, and
this is pretty consistently done across the board.

If we are going to do this, which I personally see no reason
for, we should do it across the whole networking.

Consistency is much more important than whatever reason you
could come up with to get rid of the 'extern'.
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const
Next Topic: Re: [RFC][PATCH] Pid namespaces vs locks interaction
Goto Forum:
  


Current Time: Wed Sep 10 22:58:11 GMT 2025

Total time taken to generate the page: 0.10218 seconds