OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler
Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler [message #24846 is a reply to message #24845] Tue, 11 December 2007 10:41 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 11 Dec 2007 11:38:38 +0100

> Pavel Emelyanov wrote:
> > AFAIS there's a tiny race window between these two
> > calls - after rtnl unregistered all the vlans, but 
> > the ioctl handler isn't set to NULL yet, user can 
> > manage to call this ioctl and create one vlan device, 
> > and that this function will later BUG_ON seeing 
> > non-emply hashes.
> 
> Indeed, I can't see anything preventing this.
> 
> > I think, that we must first close the vlan ioctl
> > and only after this remove all the vlans with the
> > vlan_netlink_fini() call.
> 
> That looks correct, thanks Pavel. Dave, please apply.

Applied to net-2.6, thanks!
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH 2.6.25] netns: struct net content re-work
Next Topic: [PATCH 2.6.25] UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen (resend, wrong patch wa
Goto Forum:
  


Current Time: Wed Sep 18 00:39:05 GMT 2024

Total time taken to generate the page: 0.05038 seconds