OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv
Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv [message #24658 is a reply to message #24657] Fri, 07 December 2007 10:25 Go to previous message
Patrick McHardy is currently offline  Patrick McHardy
Messages: 107
Registered: March 2006
Senior Member
Pavel Emelyanov wrote:
> There are tree paths in it, that set the skb->proto and then
> perform common receive manipulations (basically call netif_rx()).
> 
> I think, that we can make this code flow easier to understand
> by introducing the vlan_set_encap_proto() function (I hope the 
> name is good) to setup the skb proto and merge the paths calling 
> netif_rx() together.
> 
> Surprisingly, but gcc detects this thing and merges these paths
> by itself, so this patch doesn't make the vlan module smaller.


I already have something similar queued, but your patch is a nice
cleanup on top. I'll merge it into my tree and send it out after
some testing, hopefully today.
 
Read Message
Read Message
Previous Topic: [PATCH 2.6.25] net: move trie_local and trie_main into the proc iterator
Next Topic: [PATCH] pid: Extend/Fix pid_vnr
Goto Forum:
  


Current Time: Tue Oct 14 05:43:13 GMT 2025

Total time taken to generate the page: 0.25132 seconds