OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()
Re: [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl() [message #24584 is a reply to message #24581] Thu, 06 December 2007 14:10 Go to previous messageGo to previous message
Patrick McHardy is currently offline  Patrick McHardy
Messages: 107
Registered: March 2006
Senior Member
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Thu, 06 Dec 2007 14:59:24 +0100
> 
>> Pavel Emelyanov wrote:
>>> The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
>>> doesn't release the rtnl lock.
>>
>> Thanks Pavel. I somehow recall that we already fixed this
>> one, but can't find the patch :) Dave, please apply.
> 
> I think we even added this bug to -stable, or something like
> that, didn't we?  Yikes...


No, I mixed those two patches up as well. The bug was introduced
with the vlan_netlink stuff, the -stable patch fixed an invalid
return value, but still properly dropped the lock.

This patch should of course go in -stable anyway.
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] pid: sys_wait... fixes
Next Topic: [PATCH 2.6.25] multiple namespaces in the all dst_ifdown routines
Goto Forum:
  


Current Time: Thu Aug 15 20:23:53 GMT 2024

Total time taken to generate the page: 0.02911 seconds