OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][IPVS] Fix sched registration race when checking for name collision
Re: [PATCH][IPVS] Fix sched registration race when checking for name collision [message #24339 is a reply to message #24318] Tue, 04 December 2007 08:45 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Simon Horman <horms@verge.net.au>
Date: Tue, 4 Dec 2007 10:41:43 +0900

> On Mon, Dec 03, 2007 at 01:10:57PM +0300, Pavel Emelyanov wrote:
> > The register_ip_vs_scheduler() checks for the scheduler with the
> > same name under the read-locked __ip_vs_sched_lock, then drops,
> > takes it for writing and puts the scheduler in list.
> > 
> > This is racy, since we can have a race window between the lock
> > being re-locked for writing.
> > 
> > The fix is to search the scheduler with the given name right under
> > the write-locked __ip_vs_sched_lock.
> 
> This looks correct to me.
> 
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> 
> Acked-by: Simon Horman <horms@verge.net.au>

Also applied, thanks a lot.
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH][IPVS] Don't leak sysctl tables if the scheduler registration fails
Next Topic: [PATCH 2.6.25] net: netns compilation speedup
Goto Forum:
  


Current Time: Sat Jul 27 20:34:20 GMT 2024

Total time taken to generate the page: 0.02784 seconds