OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][IPVS] Don't leak sysctl tables if the scheduler registration fails
Re: [PATCH][IPVS] Don't leak sysctl tables if the scheduler registration fails [message #24338 is a reply to message #24316] Tue, 04 December 2007 08:43 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Simon Horman <horms@verge.net.au>
Date: Tue, 4 Dec 2007 10:36:48 +0900

> On Mon, Dec 03, 2007 at 01:04:53PM +0300, Pavel Emelyanov wrote:
> > In case we load lblc or lblcr module we can leak some sysctl
> > tables if the call to register_ip_vs_scheduler() fails.
> 
> This looks correct to me.
> 
> > I've looked at the register_ip_vs_scheduler() code and saw, that
> > the only reason to fail is the name collision, so I think that
> > with some 3rd party schedulers this becomes a relevant issue. No?
> 
> I guess so. Though presumably register_ip_vs_scheduler() could
> have other modes of failure in the future.
> 
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> 
> Acked-by: Simon Horman <horms@verge.net.au>

Applied, thanks.
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH] AB-BA deadlock in drop_caches sysctl (resend, the one sent was for 2.6.18)
Next Topic: [PATCH][IPVS] Fix sched registration race when checking for name collision
Goto Forum:
  


Current Time: Sun Oct 06 18:27:56 GMT 2024

Total time taken to generate the page: 0.04712 seconds