OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][SHMEM] Factor out sbi->free_inodes manipulations
Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations [message #23819 is a reply to message #23806] Tue, 27 November 2007 08:36 Go to previous message
Hugh Dickins is currently offline  Hugh Dickins
Messages: 16
Registered: September 2007
Junior Member
On Mon, 26 Nov 2007, Andrew Morton wrote:
> 
> It is peculair to (wrongly) return -ENOMEM
> 
> > +	if (shmem_reserve_inode(inode->i_sb))
> > +		return -ENOSPC;
> 
> and to then correct it in the caller..

Oops, I missed that completely.

> Something boringly conventional such as the below, perhaps?

Much better, thanks.

Hugh
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 2.6.24-rc3-mm1] IPC: consolidate sem_exit_ns(), msg_exit_ns and shm_exit_ns()
Next Topic: [PATCH][BRIDGE] Properly dereference the br_should_route_hook
Goto Forum:
  


Current Time: Tue Jul 15 03:53:23 GMT 2025

Total time taken to generate the page: 0.03505 seconds