OpenVZ Forum: Devel » [PATCH][SHMEM] Factor out sbi->free

Home » Mailing lists » Devel » [PATCH][SHMEM] Factor out sbi->free_inodes manipulations

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations [message #23819 is a reply to message #23806]

Tue, 27 November 2007 08:36

Hugh Dickins
Messages: 16
Registered: September 2007

Junior Member

On Mon, 26 Nov 2007, Andrew Morton wrote:
> 
> It is peculair to (wrongly) return -ENOMEM
> 
> > +	if (shmem_reserve_inode(inode->i_sb))
> > +		return -ENOSPC;
> 
> and to then correct it in the caller..

Oops, I missed that completely.

> Something boringly conventional such as the below, perhaps?

Much better, thanks.

Hugh

Report message to a moderator

[Message index]

		[PATCH][SHMEM] Factor out sbi->free_inodes manipulations By: Pavel Emelianov on Thu, 22 November 2007 16:57
		Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations By: Hugh Dickins on Fri, 23 November 2007 13:41
		Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations By: Pavel Emelianov on Fri, 23 November 2007 13:53
		Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations By: akpm on Tue, 27 November 2007 05:23
		Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations By: Hugh Dickins on Tue, 27 November 2007 08:36

Previous Topic:	[PATCH 2.6.24-rc3-mm1] IPC: consolidate sem_exit_ns(), msg_exit_ns and shm_exit_ns()
Next Topic:	[PATCH][BRIDGE] Properly dereference the br_should_route_hook

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Dec 21 10:20:29 GMT 2025

Total time taken to generate the page: 0.24865 seconds